* [PATCH net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls
@ 2022-02-16 7:51 Xu Wang
2022-02-18 5:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2022-02-16 7:51 UTC (permalink / raw)
To: wintera, wenjia, hca, gor, agordeev, svens
Cc: linux-s390, netdev, linux-kernel
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Alexandra Winter <wintera@linux.ibm.com>
---
drivers/s390/net/qeth_l3_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 9251ad276ee8..d2f422a9a4f7 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -1961,7 +1961,6 @@ static void qeth_l3_remove_device(struct ccwgroup_device *cgdev)
if (card->dev->reg_state == NETREG_REGISTERED)
unregister_netdev(card->dev);
- flush_workqueue(card->cmd_wq);
destroy_workqueue(card->cmd_wq);
qeth_l3_clear_ip_htable(card, 0);
qeth_l3_clear_ipato_list(card);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls
2022-02-16 7:51 [PATCH net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls Xu Wang
@ 2022-02-18 5:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-18 5:00 UTC (permalink / raw)
To: Xu Wang
Cc: wintera, wenjia, hca, gor, agordeev, svens, linux-s390, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 16 Feb 2022 07:51:55 +0000 you wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> Acked-by: Alexandra Winter <wintera@linux.ibm.com>
>
> [...]
Here is the summary with links:
- [net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls
https://git.kernel.org/netdev/net-next/c/129c77b5692d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-18 5:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-16 7:51 [PATCH net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls Xu Wang
2022-02-18 5:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox