* [PATCH] qed: remove unnecessary memset in qed_init_fw_funcs
@ 2022-03-18 9:31 Wan Jiabing
2022-03-21 11:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2022-03-18 9:31 UTC (permalink / raw)
To: Ariel Elior, Manish Chopra, David S. Miller, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel
Cc: Wan Jiabing
allocated_mem is allocated by kcalloc(). The memory is set to zero.
It is unnecessary to call memset again.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c
index 0ce37f2460a4..407029a36fa1 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c
@@ -1835,8 +1835,6 @@ struct phys_mem_desc *qed_fw_overlay_mem_alloc(struct qed_hwfn *p_hwfn,
if (!allocated_mem)
return NULL;
- memset(allocated_mem, 0, NUM_STORMS * sizeof(struct phys_mem_desc));
-
/* For each Storm, set physical address in RAM */
while (buf_offset < buf_size) {
struct phys_mem_desc *storm_mem_desc;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] qed: remove unnecessary memset in qed_init_fw_funcs
2022-03-18 9:31 [PATCH] qed: remove unnecessary memset in qed_init_fw_funcs Wan Jiabing
@ 2022-03-21 11:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-21 11:10 UTC (permalink / raw)
To: Wan Jiabing; +Cc: aelior, manishc, davem, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 18 Mar 2022 17:31:53 +0800 you wrote:
> allocated_mem is allocated by kcalloc(). The memory is set to zero.
> It is unnecessary to call memset again.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- qed: remove unnecessary memset in qed_init_fw_funcs
https://git.kernel.org/netdev/net-next/c/b8f7544a6cb3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-21 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-18 9:31 [PATCH] qed: remove unnecessary memset in qed_init_fw_funcs Wan Jiabing
2022-03-21 11:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox