* [PATCH net] net/smc: Remove redundant refcount increase
@ 2022-08-29 14:53 liuyacan
2022-08-29 16:00 ` Tony Lu
2022-09-01 5:42 ` [PATCH net] " Wenjia Zhang
0 siblings, 2 replies; 6+ messages in thread
From: liuyacan @ 2022-08-29 14:53 UTC (permalink / raw)
To: kgraul, davem, wenjia, edumazet, kuba, pabeni
Cc: linux-s390, netdev, linux-kernel, liuyacan
From: liuyacan <liuyacan@corp.netease.com>
For passive connections, the refcount increment has been done in
smc_clcsock_accept()-->smc_sock_alloc().
Fixes: 3b2dec2603d5("net/smc: restructure client and server code in af_smc")
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
---
net/smc/af_smc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 79c1318af..0939cc3b9 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
{
struct sock *newsmcsk = &new_smc->sk;
- sk_refcnt_debug_inc(newsmcsk);
if (newsmcsk->sk_state == SMC_INIT)
newsmcsk->sk_state = SMC_ACTIVE;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] net/smc: Remove redundant refcount increase
2022-08-29 14:53 [PATCH net] net/smc: Remove redundant refcount increase liuyacan
@ 2022-08-29 16:00 ` Tony Lu
2022-08-30 15:23 ` [PATCH net v2] " liuyacan
2022-09-01 5:42 ` [PATCH net] " Wenjia Zhang
1 sibling, 1 reply; 6+ messages in thread
From: Tony Lu @ 2022-08-29 16:00 UTC (permalink / raw)
To: liuyacan
Cc: kgraul, davem, wenjia, edumazet, kuba, pabeni, linux-s390, netdev,
linux-kernel
On Mon, Aug 29, 2022 at 10:53:29PM +0800, liuyacan@corp.netease.com wrote:
> From: liuyacan <liuyacan@corp.netease.com>
>
> For passive connections, the refcount increment has been done in
> smc_clcsock_accept()-->smc_sock_alloc().
>
> Fixes: 3b2dec2603d5("net/smc: restructure client and server code in af_smc")
> Signed-off-by: liuyacan <liuyacan@corp.netease.com>
> ---
> net/smc/af_smc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 79c1318af..0939cc3b9 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
> {
> struct sock *newsmcsk = &new_smc->sk;
>
> - sk_refcnt_debug_inc(newsmcsk);
> if (newsmcsk->sk_state == SMC_INIT)
Thank you for the fixes, I will test it in the CI.
Thanks.
Tony Lu
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH net v2] net/smc: Remove redundant refcount increase
2022-08-29 16:00 ` Tony Lu
@ 2022-08-30 15:23 ` liuyacan
2022-09-01 6:49 ` Tony Lu
2022-09-01 8:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 6+ messages in thread
From: liuyacan @ 2022-08-30 15:23 UTC (permalink / raw)
To: tonylu
Cc: davem, edumazet, kgraul, kuba, linux-kernel, linux-s390, liuyacan,
netdev, pabeni, wenjia, hwippel, ubraun
From: Yacan Liu <liuyacan@corp.netease.com>
For passive connections, the refcount increment has been done in
smc_clcsock_accept()-->smc_sock_alloc().
Fixes: 3b2dec2603d5 ("net/smc: restructure client and server code in af_smc")
Signed-off-by: Yacan Liu <liuyacan@corp.netease.com>
---
Change in v2:
-- Tune commit message
---
net/smc/af_smc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 79c1318af..0939cc3b9 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
{
struct sock *newsmcsk = &new_smc->sk;
- sk_refcnt_debug_inc(newsmcsk);
if (newsmcsk->sk_state == SMC_INIT)
newsmcsk->sk_state = SMC_ACTIVE;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net v2] net/smc: Remove redundant refcount increase
2022-08-30 15:23 ` [PATCH net v2] " liuyacan
@ 2022-09-01 6:49 ` Tony Lu
2022-09-01 8:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: Tony Lu @ 2022-09-01 6:49 UTC (permalink / raw)
To: liuyacan
Cc: davem, edumazet, kgraul, kuba, linux-kernel, linux-s390, netdev,
pabeni, wenjia, hwippel, ubraun
On Tue, Aug 30, 2022 at 11:23:14PM +0800, liuyacan@corp.netease.com wrote:
> From: Yacan Liu <liuyacan@corp.netease.com>
>
> For passive connections, the refcount increment has been done in
> smc_clcsock_accept()-->smc_sock_alloc().
>
> Fixes: 3b2dec2603d5 ("net/smc: restructure client and server code in af_smc")
> Signed-off-by: Yacan Liu <liuyacan@corp.netease.com>
>
> ---
> Change in v2:
> -- Tune commit message
> ---
> net/smc/af_smc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 79c1318af..0939cc3b9 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
> {
> struct sock *newsmcsk = &new_smc->sk;
>
> - sk_refcnt_debug_inc(newsmcsk);
> if (newsmcsk->sk_state == SMC_INIT)
> newsmcsk->sk_state = SMC_ACTIVE;
>
Thanks for this fixes. I dig into this sk_refcnt_debug_* facility. It
seems this is a very old debug methods and doesn't help a lot for sock
leak issue. Maybe there is another method to help track this issue?
For this patch, It looks good for me and tested in our environment.
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Cheers,
Tony Lu
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net v2] net/smc: Remove redundant refcount increase
2022-08-30 15:23 ` [PATCH net v2] " liuyacan
2022-09-01 6:49 ` Tony Lu
@ 2022-09-01 8:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-01 8:20 UTC (permalink / raw)
To: None
Cc: tonylu, davem, edumazet, kgraul, kuba, linux-kernel, linux-s390,
netdev, pabeni, wenjia, hwippel, ubraun
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 30 Aug 2022 23:23:14 +0800 you wrote:
> From: Yacan Liu <liuyacan@corp.netease.com>
>
> For passive connections, the refcount increment has been done in
> smc_clcsock_accept()-->smc_sock_alloc().
>
> Fixes: 3b2dec2603d5 ("net/smc: restructure client and server code in af_smc")
> Signed-off-by: Yacan Liu <liuyacan@corp.netease.com>
>
> [...]
Here is the summary with links:
- [net,v2] net/smc: Remove redundant refcount increase
https://git.kernel.org/netdev/net/c/a8424a9b4522
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] net/smc: Remove redundant refcount increase
2022-08-29 14:53 [PATCH net] net/smc: Remove redundant refcount increase liuyacan
2022-08-29 16:00 ` Tony Lu
@ 2022-09-01 5:42 ` Wenjia Zhang
1 sibling, 0 replies; 6+ messages in thread
From: Wenjia Zhang @ 2022-09-01 5:42 UTC (permalink / raw)
To: liuyacan
Cc: linux-s390, netdev, linux-kernel, davem, edumazet, kuba, pabeni,
kgraul, Jan Karcher
On 29.08.22 16:53, liuyacan@corp.netease.com wrote:
> From: liuyacan <liuyacan@corp.netease.com>
>
> For passive connections, the refcount increment has been done in
> smc_clcsock_accept()-->smc_sock_alloc().
>
> Fixes: 3b2dec2603d5("net/smc: restructure client and server code in af_smc")
> Signed-off-by: liuyacan <liuyacan@corp.netease.com>
> ---
> net/smc/af_smc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 79c1318af..0939cc3b9 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
> {
> struct sock *newsmcsk = &new_smc->sk;
>
> - sk_refcnt_debug_inc(newsmcsk);
> if (newsmcsk->sk_state == SMC_INIT)
> newsmcsk->sk_state = SMC_ACTIVE;
>
Good catch! Thank you for the patch! But fixes should go to the net-next
tree.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-01 8:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-29 14:53 [PATCH net] net/smc: Remove redundant refcount increase liuyacan
2022-08-29 16:00 ` Tony Lu
2022-08-30 15:23 ` [PATCH net v2] " liuyacan
2022-09-01 6:49 ` Tony Lu
2022-09-01 8:20 ` patchwork-bot+netdevbpf
2022-09-01 5:42 ` [PATCH net] " Wenjia Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox