* [bpf-next v2] bpf: use kvmemdup_bpfptr helper
@ 2022-09-13 8:40 Wang Yufen
2022-09-13 22:30 ` Stanislav Fomichev
2022-09-16 19:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Wang Yufen @ 2022-09-13 8:40 UTC (permalink / raw)
To: ast, daniel, john.fastabend, andrii, martin.lau, song, yhs,
kpsingh, sdf, haoluo, jolsa
Cc: bpf, linux-kernel
Use kvmemdup_bpfptr helper instead of open-coding to
simplify the code.
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
kernel/bpf/syscall.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 4fb08c4..f862406 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -1416,19 +1416,14 @@ static int map_update_elem(union bpf_attr *attr, bpfptr_t uattr)
}
value_size = bpf_map_value_size(map);
-
- err = -ENOMEM;
- value = kvmalloc(value_size, GFP_USER | __GFP_NOWARN);
- if (!value)
+ value = kvmemdup_bpfptr(uvalue, value_size);
+ if (IS_ERR(value)) {
+ err = PTR_ERR(value);
goto free_key;
-
- err = -EFAULT;
- if (copy_from_bpfptr(value, uvalue, value_size) != 0)
- goto free_value;
+ }
err = bpf_map_update_value(map, f, key, value, attr->flags);
-free_value:
kvfree(value);
free_key:
kvfree(key);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [bpf-next v2] bpf: use kvmemdup_bpfptr helper
2022-09-13 8:40 [bpf-next v2] bpf: use kvmemdup_bpfptr helper Wang Yufen
@ 2022-09-13 22:30 ` Stanislav Fomichev
2022-09-16 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Stanislav Fomichev @ 2022-09-13 22:30 UTC (permalink / raw)
To: Wang Yufen
Cc: ast, daniel, john.fastabend, andrii, martin.lau, song, yhs,
kpsingh, haoluo, jolsa, bpf, linux-kernel
On Tue, Sep 13, 2022 at 1:29 AM Wang Yufen <wangyufen@huawei.com> wrote:
>
> Use kvmemdup_bpfptr helper instead of open-coding to
> simplify the code.
>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
> ---
> kernel/bpf/syscall.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index 4fb08c4..f862406 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -1416,19 +1416,14 @@ static int map_update_elem(union bpf_attr *attr, bpfptr_t uattr)
> }
>
> value_size = bpf_map_value_size(map);
> -
> - err = -ENOMEM;
> - value = kvmalloc(value_size, GFP_USER | __GFP_NOWARN);
> - if (!value)
> + value = kvmemdup_bpfptr(uvalue, value_size);
> + if (IS_ERR(value)) {
> + err = PTR_ERR(value);
> goto free_key;
> -
> - err = -EFAULT;
> - if (copy_from_bpfptr(value, uvalue, value_size) != 0)
> - goto free_value;
> + }
>
> err = bpf_map_update_value(map, f, key, value, attr->flags);
>
> -free_value:
> kvfree(value);
> free_key:
> kvfree(key);
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [bpf-next v2] bpf: use kvmemdup_bpfptr helper
2022-09-13 8:40 [bpf-next v2] bpf: use kvmemdup_bpfptr helper Wang Yufen
2022-09-13 22:30 ` Stanislav Fomichev
@ 2022-09-16 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-16 19:20 UTC (permalink / raw)
To: Wang Yufen
Cc: ast, daniel, john.fastabend, andrii, martin.lau, song, yhs,
kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Tue, 13 Sep 2022 16:40:33 +0800 you wrote:
> Use kvmemdup_bpfptr helper instead of open-coding to
> simplify the code.
>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
> kernel/bpf/syscall.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Here is the summary with links:
- [bpf-next,v2] bpf: use kvmemdup_bpfptr helper
https://git.kernel.org/bpf/bpf-next/c/a02c118ee9e8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-16 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-13 8:40 [bpf-next v2] bpf: use kvmemdup_bpfptr helper Wang Yufen
2022-09-13 22:30 ` Stanislav Fomichev
2022-09-16 19:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox