* [PATCH net-next] net: ethernet: ave: Remove duplicate phy_resume() calls
@ 2022-10-24 7:23 Kunihiko Hayashi
2022-10-27 3:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Kunihiko Hayashi @ 2022-10-24 7:23 UTC (permalink / raw)
To: Heiner Kallweit, David S . Miller , Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Andrew Lunn, Russell King
Cc: netdev, linux-kernel, Kunihiko Hayashi
ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no
need to call phy_resume() explicitly. Remove it.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
drivers/net/ethernet/socionext/sni_ave.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
index d2c6a5dfdc0e..c6a6c9ed5365 100644
--- a/drivers/net/ethernet/socionext/sni_ave.c
+++ b/drivers/net/ethernet/socionext/sni_ave.c
@@ -1766,12 +1766,6 @@ static int ave_resume(struct device *dev)
wol.wolopts = priv->wolopts;
__ave_ethtool_set_wol(ndev, &wol);
- if (ndev->phydev) {
- ret = phy_resume(ndev->phydev);
- if (ret)
- return ret;
- }
-
if (netif_running(ndev)) {
ret = ave_open(ndev);
netif_device_attach(ndev);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: ethernet: ave: Remove duplicate phy_resume() calls
2022-10-24 7:23 [PATCH net-next] net: ethernet: ave: Remove duplicate phy_resume() calls Kunihiko Hayashi
@ 2022-10-27 3:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-27 3:30 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: hkallweit1, davem, edumazet, kuba, pabeni, andrew, linux, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 24 Oct 2022 16:23:14 +0900 you wrote:
> ave_open() in ave_resume() executes __phy_resume() via phy_start(), so no
> need to call phy_resume() explicitly. Remove it.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> drivers/net/ethernet/socionext/sni_ave.c | 6 ------
> 1 file changed, 6 deletions(-)
Here is the summary with links:
- [net-next] net: ethernet: ave: Remove duplicate phy_resume() calls
https://git.kernel.org/netdev/net-next/c/3a6573b7a218
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-27 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 7:23 [PATCH net-next] net: ethernet: ave: Remove duplicate phy_resume() calls Kunihiko Hayashi
2022-10-27 3:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox