From: Valdis.Kletnieks@vt.edu
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
x86@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
Jason Wessel <jason.wessel@windriver.com>,
kgdb-bugreport@lists.sourceforge.net,
Hedi Berriche <hedi@sgi.com>, Mike Travis <travis@sgi.com>,
Dimitri Sivanich <sivanich@sgi.com>,
Steven Rostedt <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] printk: Use symbolic defines for console loglevels
Date: Tue, 20 May 2014 01:44:42 -0400 [thread overview]
Message-ID: <16681.1400564682@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 19 May 2014 20:27:32 +0200." <1400524052-25625-1-git-send-email-bp@alien8.de>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Mon, 19 May 2014 20:27:32 +0200, Borislav Petkov said:
> From: Borislav Petkov <bp@suse.de>
>
> ... instead of naked numbers.
>
> Stuff in sysrq.c used to set it to 8 which is supposed to mean above
> default level so set it to DEBUG instead as we're terminating/killing
> all tasks and we want to be verbose there.
>
> There should be no functionality change resulting from this patch.
After a quick eyeballing, looks like it, except for:
> +++ b/arch/x86/kernel/head64.c
> @@ -172,7 +172,7 @@ asmlinkage __visible void __init x86_64_start_kernel(char
* real_mode_data)
> */
> load_ucode_bsp();
>
> - if (console_loglevel == 10)
> + if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG)
> early_printk("Kernel alive\n");
But this looks like a bugfix that changes the behavior for loglevels > 11.
Having said that, it's probably OK to not split the bugfix out to
a separate patch....
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2014-05-20 5:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 18:27 [PATCH] printk: Use symbolic defines for console loglevels Borislav Petkov
2014-05-19 19:12 ` Joe Perches
2014-05-19 19:25 ` Borislav Petkov
2014-05-19 19:36 ` Kees Cook
2014-05-19 20:38 ` Randy Dunlap
2014-05-20 5:44 ` Valdis.Kletnieks [this message]
2014-05-27 19:17 ` Steven Rostedt
2014-05-27 19:43 ` Borislav Petkov
2014-05-27 22:36 ` Valdis.Kletnieks
2014-05-27 22:59 ` Borislav Petkov
2014-05-27 23:26 ` Andrew Morton
2014-05-27 23:32 ` Steven Rostedt
2014-05-27 23:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16681.1400564682@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=hedi@sgi.com \
--cc=jason.wessel@windriver.com \
--cc=jslaby@suse.cz \
--cc=keescook@chromium.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sivanich@sgi.com \
--cc=torvalds@linux-foundation.org \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox