Re: [PATCH] printk: Use symbolic defines for console loglevels

[Randy Dunlap <rdunlap@infradead.org>]

On 05/19/2014 11:27 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> ... instead of naked numbers.
> 
> Stuff in sysrq.c used to set it to 8 which is supposed to mean above
> default level so set it to DEBUG instead as we're terminating/killing
> all tasks and we want to be verbose there.
> 
> There should be no functionality change resulting from this patch.
> 

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: x86@kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: Jason Wessel <jason.wessel@windriver.com>
> Cc: kgdb-bugreport@lists.sourceforge.net
> Cc: Hedi Berriche <hedi@sgi.com>
> Cc: Mike Travis <travis@sgi.com>
> Cc: Dimitri Sivanich <sivanich@sgi.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>  arch/x86/kernel/head64.c      |  2 +-
>  arch/x86/platform/uv/uv_nmi.c |  2 +-
>  drivers/nubus/nubus.c         | 18 +++++++++---------
>  drivers/tty/sysrq.c           |  8 ++++----
>  include/linux/printk.h        | 15 +++++++++++++--
>  init/main.c                   |  4 ++--
>  kernel/debug/kdb/kdb_bt.c     |  2 +-
>  kernel/debug/kdb/kdb_io.c     |  2 +-
>  kernel/debug/kdb/kdb_main.c   |  2 +-
>  kernel/printk/printk.c        | 13 +++----------
>  10 files changed, 36 insertions(+), 32 deletions(-)


-- 
~Randy