From: Arnd Bergmann <arnd@linaro.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible
Date: Mon, 29 Aug 2016 12:54:55 +0200 [thread overview]
Message-ID: <16746903.dkEEJ6ppqu@wuerfel> (raw)
In-Reply-To: <1472318124-25541-1-git-send-email-baoyou.xie@linaro.org>
On Sunday, August 28, 2016 1:15:24 AM CEST Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:
> drivers/mailbox/bcm-pdc-mailbox.c:472:6: warning: no previous prototype for 'pdc_setup_debugfs' [-Wmissing-prototypes]
> drivers/mailbox/bcm-pdc-mailbox.c:488:6: warning: no previous prototype for 'pdc_free_debugfs' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2016-08-29 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 17:15 [PATCH] fix:mailbox:bcm-pdc-mailbox:mark symbols static where possible Baoyou Xie
2016-08-29 10:54 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16746903.dkEEJ6ppqu@wuerfel \
--to=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox