[PATCH net-next v3 0/2] Update CPSW bindings for Serdes PHY

[PATCH net-next v3 0/2] Update CPSW bindings for Serdes PHY

[Siddharth Vadapalli]

Hello,

This series adds documentation for the Serdes PHY. Also, the name used to
refer to the Serdes PHY in the am65-cpsw driver is updated to match the
documented name.

---
Documenting the Serdes PHY bindings was missed out in the already merged
series at:
https://lore.kernel.org/r/20230104103432.1126403-1-s-vadapalli@ti.com/
This miss was pointed out at:
https://lore.kernel.org/r/CAMuHMdW5atq-FuLEL3htuE3t2uO86anLL3zeY7n1RqqMP_rH1g@mail.gmail.com/

Changes from v2:
1. Drop "phy" suffixes in the phy-names property, changing "mac-phy" and
   "serdes-phy" to "mac" and "serdes".
2. Add a new patch to update the name used by the am65-cpsw driver to
   refer to the Serdes PHY, from "serdes-phy" to "serdes".

Changes from v1:
1. Describe phys property with minItems, items and description.
2. Use minItems and items in phy-names.
3. Remove the description in phy-names.

v2:
https://lore.kernel.org/r/20230308051835.276552-1-s-vadapalli@ti.com/
v1:
https://lore.kernel.org/r/20230306094750.159657-1-s-vadapalli@ti.com/

Siddharth Vadapalli (2):
  dt-bindings: net: ti: k3-am654-cpsw-nuss: Document Serdes PHY
  net: ethernet: ti: am65-cpsw: Update name of Serdes PHY

 .../bindings/net/ti,k3-am654-cpsw-nuss.yaml        | 14 ++++++++++++--
 drivers/net/ethernet/ti/am65-cpsw-nuss.c           |  2 +-
 2 files changed, 13 insertions(+), 3 deletions(-)

-- 
2.25.1

[PATCH net-next v3 1/2] dt-bindings: net: ti: k3-am654-cpsw-nuss: Document Serdes PHY

[Siddharth Vadapalli]

Update bindings to include Serdes PHY as an optional PHY, in addition to
the existing CPSW MAC's PHY. The CPSW MAC's PHY is required while the
Serdes PHY is optional. The Serdes PHY handle has to be provided only
when the Serdes is being configured in a Single-Link protocol. Using the
name "serdes-phy" to represent the Serdes PHY handle, the am65-cpsw-nuss
driver can obtain the Serdes PHY and request the Serdes to be
configured.

Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
 .../bindings/net/ti,k3-am654-cpsw-nuss.yaml        | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
index 900063411a20..628d63e1eb1f 100644
--- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
+++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
@@ -126,8 +126,18 @@ properties:
             description: CPSW port number
 
           phys:
-            maxItems: 1
-            description: phandle on phy-gmii-sel PHY
+            minItems: 1
+            items:
+              - description: CPSW MAC's PHY.
+              - description: Serdes PHY. Serdes PHY is required only if
+                             the Serdes has to be configured in the
+                             Single-Link configuration.
+
+          phy-names:
+            minItems: 1
+            items:
+              - const: mac
+              - const: serdes
 
           label:
             description: label associated with this port
-- 
2.25.1

[PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw: Update name of Serdes PHY

[Siddharth Vadapalli]

The bindings for the am65-cpsw driver use the name "serdes" to refer to
the Serdes PHY. Thus, update the name used for the Serdes PHY within the
am65_cpsw_init_serdes_phy() function from "serdes-phy" to "serdes".

Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 4e3861c47708..dddfebd6be41 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1466,7 +1466,7 @@ static void am65_cpsw_disable_serdes_phy(struct am65_cpsw_common *common)
 static int am65_cpsw_init_serdes_phy(struct device *dev, struct device_node *port_np,
 				     struct am65_cpsw_port *port)
 {
-	const char *name = "serdes-phy";
+	const char *name = "serdes";
 	struct phy *phy;
 	int ret;
 
-- 
2.25.1

Re: [PATCH net-next v3 1/2] dt-bindings: net: ti: k3-am654-cpsw-nuss: Document Serdes PHY

[Krzysztof Kozlowski]

On 09/03/2023 08:36, Siddharth Vadapalli wrote:
> Update bindings to include Serdes PHY as an optional PHY, in addition to
> the existing CPSW MAC's PHY. The CPSW MAC's PHY is required while the
> Serdes PHY is optional. The Serdes PHY handle has to be provided only
> when the Serdes is being configured in a Single-Link protocol. Using the
> name "serdes-phy" to represent the Serdes PHY handle, the am65-cpsw-nuss
> driver can obtain the Serdes PHY and request the Serdes to be
> configured.
> 
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH net-next v3 0/2] Update CPSW bindings for Serdes PHY

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 9 Mar 2023 13:06:10 +0530 you wrote:
> Hello,
> 
> This series adds documentation for the Serdes PHY. Also, the name used to
> refer to the Serdes PHY in the am65-cpsw driver is updated to match the
> documented name.
> 
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/2] dt-bindings: net: ti: k3-am654-cpsw-nuss: Document Serdes PHY
    https://git.kernel.org/netdev/net-next/c/aacaf7b3d19d
  - [net-next,v3,2/2] net: ethernet: ti: am65-cpsw: Update name of Serdes PHY
    https://git.kernel.org/netdev/net-next/c/bca93b20c397

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html