* [PATCH net-next v2] net: ethernet: mtk_eth_soc: use be32 type to store be32 values
@ 2023-04-07 13:26 Simon Horman
2023-04-11 1:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2023-04-07 13:26 UTC (permalink / raw)
To: Jakub Kicinski, David S. Miller, Eric Dumazet, Paolo Abeni
Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
Lorenzo Bianconi, Matthias Brugger, AngeloGioacchino Del Regno,
Andrew Lunn, netdev, linux-kernel, linux-arm-kernel,
linux-mediatek
n_addr is used to store be32 values,
so a sparse-friendly array of be32 to store these values.
Flagged by sparse:
.../mtk_ppe_debugfs.c:59:27: warning: incorrect type in assignment (different base types)
.../mtk_ppe_debugfs.c:59:27: expected unsigned int
.../mtk_ppe_debugfs.c:59:27: got restricted __be32 [usertype]
.../mtk_ppe_debugfs.c:161:46: warning: cast to restricted __be16
No functional changes intended.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
Changes in v2:
- Drop change to make use of the cpu_to_be32_array helper.
It was suggested that a new helper is in order.
Let's leave that as a follow-up.
- Link to v1: https://lore.kernel.org/r/20230401-mtk_eth_soc-sparse-v1-1-84e9fc7b8eab@kernel.org
---
drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
index 53cf87e9acbb..316fe2e70fea 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c
@@ -47,7 +47,7 @@ static const char *mtk_foe_pkt_type_str(int type)
static void
mtk_print_addr(struct seq_file *m, u32 *addr, bool ipv6)
{
- u32 n_addr[4];
+ __be32 n_addr[4];
int i;
if (!ipv6) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next v2] net: ethernet: mtk_eth_soc: use be32 type to store be32 values
2023-04-07 13:26 [PATCH net-next v2] net: ethernet: mtk_eth_soc: use be32 type to store be32 values Simon Horman
@ 2023-04-11 1:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-11 1:40 UTC (permalink / raw)
To: Simon Horman
Cc: kuba, davem, edumazet, pabeni, nbd, john, sean.wang, Mark-MC.Lee,
lorenzo, matthias.bgg, angelogioacchino.delregno, andrew, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 07 Apr 2023 15:26:51 +0200 you wrote:
> n_addr is used to store be32 values,
> so a sparse-friendly array of be32 to store these values.
>
> Flagged by sparse:
> .../mtk_ppe_debugfs.c:59:27: warning: incorrect type in assignment (different base types)
> .../mtk_ppe_debugfs.c:59:27: expected unsigned int
> .../mtk_ppe_debugfs.c:59:27: got restricted __be32 [usertype]
> .../mtk_ppe_debugfs.c:161:46: warning: cast to restricted __be16
>
> [...]
Here is the summary with links:
- [net-next,v2] net: ethernet: mtk_eth_soc: use be32 type to store be32 values
https://git.kernel.org/netdev/net-next/c/9bc11460bea7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-11 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 13:26 [PATCH net-next v2] net: ethernet: mtk_eth_soc: use be32 type to store be32 values Simon Horman
2023-04-11 1:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox