From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Robert Moore <robert.moore@intel.com>,
Lv Zheng <lv.zheng@intel.com>,
"Rafael J.Wysocki" <rafael.j.wysocki@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>,
Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Subject: Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device
Date: Tue, 21 Jun 2016 17:11:41 +0200 [thread overview]
Message-ID: <1688032.bsOGLjkyBG@vostro.rjw.lan> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A0337D46442AB@SW-EX-MBX01.diasemi.com>
On Tuesday, June 21, 2016 11:50:01 AM Opensource [Adam Thomson] wrote:
> 21 June 2016 12:42, Rafael J. Wysocki wrote:
>
> > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode,
> > > > + const char *name)
> > > > +{
> > > > + return is_acpi_data_node(fwnode) ?
> > > > + (!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false;
> > > > +}
> > >
> > > Looks fine to me.
> > >
> > > One question - is it expected that matching ACPI data nodes is always
> > > case insensitive?
> >
> > That would not be a correct expectation in theory, although I don't think it
> > really matters in practice.
>
> From my reading of the Hierarchical Data Extension and ACPI Spec, I thought
> that was the case (section 19.3.1 ASL Names - ASL names are not case-sensitive
> and will be converted to upper case).
Section 19.3.1 is applicable to object names and not to the data returned
by those objects. The link names in the Hierarchical Data Extension are
data returned by _DSD (or other objects related to it). They are general ACPI
strings and those are case-sensitive.
Thanks,
Rafael
next prev parent reply other threads:[~2016-06-21 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1466421714.git.Adam.Thomson.Opensource@diasemi.com>
[not found] ` <866c9edccdd89805f6a0c0aa92f8a78ae616ed61.1466421714.git.Adam.Thomson.Opensource@diasemi.com>
2016-06-21 10:20 ` [RESEND PATCH v3 1/2] device property: Add function to search for named child of device Opensource [Adam Thomson]
2016-06-21 10:22 ` Andy Shevchenko
2016-06-21 11:11 ` Mika Westerberg
2016-06-21 11:42 ` Rafael J. Wysocki
2016-06-21 11:50 ` Opensource [Adam Thomson]
2016-06-21 11:59 ` Mika Westerberg
2016-06-21 15:11 ` Rafael J. Wysocki [this message]
2016-06-21 11:54 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1688032.bsOGLjkyBG@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=perex@perex.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=robh+dt@kernel.org \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox