From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Robert Moore <robert.moore@intel.com>,
Lv Zheng <lv.zheng@intel.com>,
"Rafael J.Wysocki" <rafael.j.wysocki@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Subject: Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device
Date: Tue, 21 Jun 2016 14:54:25 +0300 [thread overview]
Message-ID: <20160621115425.GY1739@lahna.fi.intel.com> (raw)
In-Reply-To: <28758107.YROb1rVtm6@vostro.rjw.lan>
On Tue, Jun 21, 2016 at 01:42:16PM +0200, Rafael J. Wysocki wrote:
> > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode,
> > > + const char *name)
> > > +{
> > > + return is_acpi_data_node(fwnode) ?
> > > + (!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false;
> > > +}
> >
> > Looks fine to me.
> >
> > One question - is it expected that matching ACPI data nodes is always
> > case insensitive?
>
> That would not be a correct expectation in theory, although I don't think it
> really matters in practice.
OK.
Maybe it is good idea to document that in acpi_data_node_match(). A
comment explaining why we use strcasecmp() for now.
prev parent reply other threads:[~2016-06-21 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1466421714.git.Adam.Thomson.Opensource@diasemi.com>
[not found] ` <866c9edccdd89805f6a0c0aa92f8a78ae616ed61.1466421714.git.Adam.Thomson.Opensource@diasemi.com>
2016-06-21 10:20 ` [RESEND PATCH v3 1/2] device property: Add function to search for named child of device Opensource [Adam Thomson]
2016-06-21 10:22 ` Andy Shevchenko
2016-06-21 11:11 ` Mika Westerberg
2016-06-21 11:42 ` Rafael J. Wysocki
2016-06-21 11:50 ` Opensource [Adam Thomson]
2016-06-21 11:59 ` Mika Westerberg
2016-06-21 15:11 ` Rafael J. Wysocki
2016-06-21 11:54 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621115425.GY1739@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=perex@perex.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=robh+dt@kernel.org \
--cc=sathyanarayana.nujella@intel.com \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox