From: Arnd Bergmann <arnd@arndb.de>
To: Lijun Pan <Lijun.Pan@freescale.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA
Date: Thu, 01 Oct 2015 10:33:31 +0200 [thread overview]
Message-ID: <1694323.vYGVsqBdJK@wuerfel> (raw)
In-Reply-To: <1443653742-23177-1-git-send-email-Lijun.Pan@freescale.com>
On Wednesday 30 September 2015 17:55:42 Lijun Pan wrote:
> Need to include sched.h to fix the following compilation error
> if FSL_IFC is enabled on ARM64 machine.
That's good, but you did not change the subject line accordingly.
> Also, sort the include files by alphabetical order.
No need to reorder the other lines, just try to fit it in as good
as possible.
> Since ./arch/arm64/include/asm/stat.h does not
> include ./arch/arm64/include/asm/compat.h,
> it will not include include/linux/sched.h
> Hence we have to manually add "#include <linux/sched.h>"
> in drivers/memory/fsl_ifc.c
Ok, good job explaining what happened.
Arnd
next prev parent reply other threads:[~2015-10-01 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 22:55 [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA Lijun Pan
2015-10-01 8:33 ` Arnd Bergmann [this message]
[not found] ` <CAPWn=R41g17MxGoxdYckQ=u4N3+_XWu+Nn0mvbTCC7ZOFtc-=w@mail.gmail.com>
2015-10-01 21:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1694323.vYGVsqBdJK@wuerfel \
--to=arnd@arndb.de \
--cc=Lijun.Pan@freescale.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox