From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Paul Bolle'" <pebolle@tiscali.nl>,
"'Ben Dooks'" <ben-linux@fluff.org>,
"'Russell King'" <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] S3C24XX: remove unneeded "config SMDK2440_CPU2442"
Date: Mon, 25 Mar 2013 10:08:38 +0900 [thread overview]
Message-ID: <16e201ce28f5$4870be90$d9523bb0$%kim@samsung.com> (raw)
In-Reply-To: <1363778011.1390.96.camel@x61.thuisdomein>
Paul Bolle wrote:
>
> The Kconfig entry for SMDK2440_CPU2442 was moved from one Kconfig file
> to another in commit acf2d41d8595829eb0ac7bf6891f4875a78d4d6e ("ARM:
> S3C24XX: Move mach-s3c2440/ pll into mach-s3c24xx/"). In that move it
> also lost its statement to select CPU_S3C2442. That was not needed
> anymore because it now depended on that same symbol.
>
> But without its select this entry became a nop: enabling it has no
> effect, as it changes no code. It can safely be removed.
>
> Fix a related, and trivial, comment typo too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> arch/arm/mach-s3c24xx/Kconfig | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
> index 37f513d..92c07a2 100644
> --- a/arch/arm/mach-s3c24xx/Kconfig
> +++ b/arch/arm/mach-s3c24xx/Kconfig
> @@ -663,10 +663,7 @@ config MACH_RX1950
> help
> Say Y here if you're using HP iPAQ rx1950
>
> -config SMDK2440_CPU2442
> - bool "SMDM2440 with S3C2442 CPU module"
> -
> -endif # CPU_S3C2440
> +endif # CPU_S3C2442
>
> if CPU_S3C2443 || CPU_S3C2416
>
> --
> 1.7.11.7
Looks good to me, applied.
Thanks.
- Kukjin
prev parent reply other threads:[~2013-03-25 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 11:13 [PATCH] S3C24XX: remove unneeded "config SMDK2440_CPU2442" Paul Bolle
2013-03-25 1:08 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='16e201ce28f5$4870be90$d9523bb0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox