* [PATCH] S3C24XX: remove unneeded "config SMDK2440_CPU2442"
@ 2013-03-20 11:13 Paul Bolle
2013-03-25 1:08 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2013-03-20 11:13 UTC (permalink / raw)
To: Ben Dooks, Kukjin Kim, Russell King
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel
The Kconfig entry for SMDK2440_CPU2442 was moved from one Kconfig file
to another in commit acf2d41d8595829eb0ac7bf6891f4875a78d4d6e ("ARM:
S3C24XX: Move mach-s3c2440/ pll into mach-s3c24xx/"). In that move it
also lost its statement to select CPU_S3C2442. That was not needed
anymore because it now depended on that same symbol.
But without its select this entry became a nop: enabling it has no
effect, as it changes no code. It can safely be removed.
Fix a related, and trivial, comment typo too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.
arch/arm/mach-s3c24xx/Kconfig | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index 37f513d..92c07a2 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -663,10 +663,7 @@ config MACH_RX1950
help
Say Y here if you're using HP iPAQ rx1950
-config SMDK2440_CPU2442
- bool "SMDM2440 with S3C2442 CPU module"
-
-endif # CPU_S3C2440
+endif # CPU_S3C2442
if CPU_S3C2443 || CPU_S3C2416
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] S3C24XX: remove unneeded "config SMDK2440_CPU2442"
2013-03-20 11:13 [PATCH] S3C24XX: remove unneeded "config SMDK2440_CPU2442" Paul Bolle
@ 2013-03-25 1:08 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2013-03-25 1:08 UTC (permalink / raw)
To: 'Paul Bolle', 'Ben Dooks', 'Russell King'
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel
Paul Bolle wrote:
>
> The Kconfig entry for SMDK2440_CPU2442 was moved from one Kconfig file
> to another in commit acf2d41d8595829eb0ac7bf6891f4875a78d4d6e ("ARM:
> S3C24XX: Move mach-s3c2440/ pll into mach-s3c24xx/"). In that move it
> also lost its statement to select CPU_S3C2442. That was not needed
> anymore because it now depended on that same symbol.
>
> But without its select this entry became a nop: enabling it has no
> effect, as it changes no code. It can safely be removed.
>
> Fix a related, and trivial, comment typo too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> arch/arm/mach-s3c24xx/Kconfig | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
> index 37f513d..92c07a2 100644
> --- a/arch/arm/mach-s3c24xx/Kconfig
> +++ b/arch/arm/mach-s3c24xx/Kconfig
> @@ -663,10 +663,7 @@ config MACH_RX1950
> help
> Say Y here if you're using HP iPAQ rx1950
>
> -config SMDK2440_CPU2442
> - bool "SMDM2440 with S3C2442 CPU module"
> -
> -endif # CPU_S3C2440
> +endif # CPU_S3C2442
>
> if CPU_S3C2443 || CPU_S3C2416
>
> --
> 1.7.11.7
Looks good to me, applied.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-25 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-20 11:13 [PATCH] S3C24XX: remove unneeded "config SMDK2440_CPU2442" Paul Bolle
2013-03-25 1:08 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox