[PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

[PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

[Pedro Tammela]

Add the dependsOn test check for all the mirred blockcast tests.
It will prevent the issue reported by LKFT which happens when an older
iproute2 is used to run the current tdc.

Tests are skipped if the dependsOn check fails.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
---
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
---
 .../selftests/tc-testing/tc-tests/actions/mirred.json      | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
index 795cf1ce8af0..b73bd255ea36 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
@@ -657,6 +657,7 @@
             "actions",
             "mirred"
         ],
+        "dependsOn": "$TC actions add action mirred help 2>&1 | grep -q blockid",
         "plugins": {
             "requires": "nsPlugin"
         },
@@ -711,6 +712,7 @@
             "actions",
             "mirred"
         ],
+        "dependsOn": "$TC actions add action mirred help 2>&1 | grep -q blockid",
         "plugins": {
             "requires": "nsPlugin"
         },
@@ -765,6 +767,7 @@
             "actions",
             "mirred"
         ],
+        "dependsOn": "$TC actions add action mirred help 2>&1 | grep -q blockid",
         "plugins": {
             "requires": "nsPlugin"
         },
@@ -819,6 +822,7 @@
             "actions",
             "mirred"
         ],
+        "dependsOn": "$TC actions add action mirred help 2>&1 | grep -q blockid",
         "plugins": {
             "requires": "nsPlugin"
         },
@@ -873,6 +877,7 @@
             "actions",
             "mirred"
         ],
+        "dependsOn": "$TC actions add action mirred help 2>&1 | grep -q blockid",
         "plugins": {
             "requires": "nsPlugin"
         },
@@ -937,6 +942,7 @@
             "actions",
             "mirred"
         ],
+        "dependsOn": "$TC actions add action mirred help 2>&1 | grep -q blockid",
         "plugins": {
             "requires": "nsPlugin"
         },
@@ -995,6 +1001,7 @@
             "actions",
             "mirred"
         ],
+        "dependsOn": "$TC actions add action mirred help 2>&1 | grep -q blockid",
         "plugins": {
             "requires": "nsPlugin"
         },
-- 
2.40.1

Re: [PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

[Naresh Kamboju]

Hi Pedro,

On Thu, 29 Feb 2024 at 20:08, Pedro Tammela <pctammela@mojatatu.com> wrote:
>
> Add the dependsOn test check for all the mirred blockcast tests.
> It will prevent the issue reported by LKFT which happens when an older
> iproute2 is used to run the current tdc.

Thank you for the fix patch.
LKFT tests run on Debian rootfs, Please suggest the packages that are needed
for tc-testing.

>
> Tests are skipped if the dependsOn check fails.

- Naresh

Re: [PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

[Pedro Tammela]

On 01/03/2024 09:24, Naresh Kamboju wrote:
> Hi Pedro,
> 
> On Thu, 29 Feb 2024 at 20:08, Pedro Tammela <pctammela@mojatatu.com> wrote:
>>
>> Add the dependsOn test check for all the mirred blockcast tests.
>> It will prevent the issue reported by LKFT which happens when an older
>> iproute2 is used to run the current tdc.
> 
> Thank you for the fix patch.
> LKFT tests run on Debian rootfs, Please suggest the packages that are needed
> for tc-testing.

I believe testing on net-next should also use (iproute2 + iproute2-next)[0].
For stable the same rule would apply linux-x.y uses the released 
iproute2-x.y.

It's my understanding that some distros ship a slightly older iproute2.
So in order to match the versions you would need to compile it.

> 
>>
>> Tests are skipped if the dependsOn check fails.
> 
> - Naresh


[0]
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git 
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git

Re: [PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 29 Feb 2024 11:38:25 -0300 you wrote:
> Add the dependsOn test check for all the mirred blockcast tests.
> It will prevent the issue reported by LKFT which happens when an older
> iproute2 is used to run the current tdc.
> 
> Tests are skipped if the dependsOn check fails.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
> 
> [...]

Here is the summary with links:
  - [net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests
    https://git.kernel.org/netdev/net-next/c/dcfaf1f758ee

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html