* [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS
@ 2024-04-14 15:49 Krzysztof Kozlowski
2024-04-15 10:20 ` Vladimir Oltean
2024-04-17 0:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-14 15:49 UTC (permalink / raw)
To: Woojung Huh, UNGLinuxDriver, Andrew Lunn, Florian Fainelli,
Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel
Cc: Krzysztof Kozlowski
The ID table already has respective entry and MODULE_DEVICE_TABLE and
creates proper alias for SPI driver. Having another MODULE_ALIAS causes
the alias to be duplicated.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/net/dsa/microchip/ksz_spi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c
index c8166fb440ab..cdc4add5f5b5 100644
--- a/drivers/net/dsa/microchip/ksz_spi.c
+++ b/drivers/net/dsa/microchip/ksz_spi.c
@@ -233,13 +233,6 @@ static struct spi_driver ksz_spi_driver = {
module_spi_driver(ksz_spi_driver);
-MODULE_ALIAS("spi:ksz9477");
-MODULE_ALIAS("spi:ksz9896");
-MODULE_ALIAS("spi:ksz9897");
-MODULE_ALIAS("spi:ksz9893");
-MODULE_ALIAS("spi:ksz9563");
-MODULE_ALIAS("spi:ksz8563");
-MODULE_ALIAS("spi:ksz9567");
MODULE_ALIAS("spi:lan937x");
MODULE_AUTHOR("Tristram Ha <Tristram.Ha@microchip.com>");
MODULE_DESCRIPTION("Microchip ksz Series Switch SPI Driver");
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS
2024-04-14 15:49 [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
@ 2024-04-15 10:20 ` Vladimir Oltean
2024-04-17 13:27 ` Krzysztof Kozlowski
2024-04-17 0:20 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Vladimir Oltean @ 2024-04-15 10:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Woojung Huh, UNGLinuxDriver, Andrew Lunn, Florian Fainelli,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, linux-kernel
On Sun, Apr 14, 2024 at 05:49:29PM +0200, Krzysztof Kozlowski wrote:
> The ID table already has respective entry and MODULE_DEVICE_TABLE and
> creates proper alias for SPI driver. Having another MODULE_ALIAS causes
> the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/net/dsa/microchip/ksz_spi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c
> index c8166fb440ab..cdc4add5f5b5 100644
> --- a/drivers/net/dsa/microchip/ksz_spi.c
> +++ b/drivers/net/dsa/microchip/ksz_spi.c
> @@ -233,13 +233,6 @@ static struct spi_driver ksz_spi_driver = {
>
> module_spi_driver(ksz_spi_driver);
>
> -MODULE_ALIAS("spi:ksz9477");
> -MODULE_ALIAS("spi:ksz9896");
> -MODULE_ALIAS("spi:ksz9897");
> -MODULE_ALIAS("spi:ksz9893");
> -MODULE_ALIAS("spi:ksz9563");
> -MODULE_ALIAS("spi:ksz8563");
> -MODULE_ALIAS("spi:ksz9567");
> MODULE_ALIAS("spi:lan937x");
The spi:lan937x alias is bogus, right? LAN937x switches are covered by
these entries in ksz_spi_ids[]:
{ "lan9370" },
{ "lan9371" },
{ "lan9372" },
{ "lan9373" },
{ "lan9374" },
> MODULE_AUTHOR("Tristram Ha <Tristram.Ha@microchip.com>");
> MODULE_DESCRIPTION("Microchip ksz Series Switch SPI Driver");
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS
2024-04-15 10:20 ` Vladimir Oltean
@ 2024-04-17 13:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-17 13:27 UTC (permalink / raw)
To: Vladimir Oltean
Cc: Woojung Huh, UNGLinuxDriver, Andrew Lunn, Florian Fainelli,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, linux-kernel
On 15/04/2024 12:20, Vladimir Oltean wrote:
> On Sun, Apr 14, 2024 at 05:49:29PM +0200, Krzysztof Kozlowski wrote:
>> The ID table already has respective entry and MODULE_DEVICE_TABLE and
>> creates proper alias for SPI driver. Having another MODULE_ALIAS causes
>> the alias to be duplicated.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>> drivers/net/dsa/microchip/ksz_spi.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c
>> index c8166fb440ab..cdc4add5f5b5 100644
>> --- a/drivers/net/dsa/microchip/ksz_spi.c
>> +++ b/drivers/net/dsa/microchip/ksz_spi.c
>> @@ -233,13 +233,6 @@ static struct spi_driver ksz_spi_driver = {
>>
>> module_spi_driver(ksz_spi_driver);
>>
>> -MODULE_ALIAS("spi:ksz9477");
>> -MODULE_ALIAS("spi:ksz9896");
>> -MODULE_ALIAS("spi:ksz9897");
>> -MODULE_ALIAS("spi:ksz9893");
>> -MODULE_ALIAS("spi:ksz9563");
>> -MODULE_ALIAS("spi:ksz8563");
>> -MODULE_ALIAS("spi:ksz9567");
>> MODULE_ALIAS("spi:lan937x");
>
> The spi:lan937x alias is bogus, right? LAN937x switches are covered by
> these entries in ksz_spi_ids[]:
>
> { "lan9370" },
> { "lan9371" },
> { "lan9372" },
> { "lan9373" },
> { "lan9374" },
No, it is not. That's a valid alias. What's bogus about it? Someone
wanted to load the module by such alias.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS
2024-04-14 15:49 [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2024-04-15 10:20 ` Vladimir Oltean
@ 2024-04-17 0:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-17 0:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: woojung.huh, UNGLinuxDriver, andrew, f.fainelli, olteanv, davem,
edumazet, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 14 Apr 2024 17:49:29 +0200 you wrote:
> The ID table already has respective entry and MODULE_DEVICE_TABLE and
> creates proper alias for SPI driver. Having another MODULE_ALIAS causes
> the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/net/dsa/microchip/ksz_spi.c | 7 -------
> 1 file changed, 7 deletions(-)
Here is the summary with links:
- [net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS
https://git.kernel.org/netdev/net-next/c/9b07508845f9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-17 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-14 15:49 [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2024-04-15 10:20 ` Vladimir Oltean
2024-04-17 13:27 ` Krzysztof Kozlowski
2024-04-17 0:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox