From: Heiko Stuebner <heiko@sntech.de>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, keescook@google.com,
leozwang@google.com, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xing.zheng@rock-chips.com
Subject: Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
Date: Sun, 10 Jan 2016 19:23:40 +0100 [thread overview]
Message-ID: <1714176.Nme8cQ9zc4@phil> (raw)
In-Reply-To: <B588B7A8-EC8A-44A5-AEDF-F75AB5361F01@rock-chips.com>
Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng:
> Hi Heiko,
>
> > 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
> >
> >
> > Hi Heiko,
> >
> >> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
> >>
> >> Hi Xing,
> >>
> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> >>> Because the RK3036 doesn't support EMAC, and only support the RMII
> >>> mode
> >>> in the EMAC IP, we refer to the TRM CRU and update the new external
> >>> clock name for EMAC.
> >>>
> >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> >>
> >> as I said in the other mail, I already fixed the original patch myself
> >> :-) So I'm just going to drop this one.
> >>
> >>
> >> Heiko
> >>
> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c
> >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931>
> > I am sorry to misunderstand.
> >
> > OK, thank you for your help. :)
>
> Your patch is:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external GMAC clock - optional
>
> I think that these should be like this:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external EMAC clock - optional
I fixed that up now, thanks for catching this.
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371
Heiko
prev parent reply other threads:[~2016-01-10 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 7:22 [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng
2016-01-10 9:59 ` Heiko Stuebner
2016-01-10 10:29 ` Xing Zheng
2016-01-10 10:36 ` Xing Zheng
2016-01-10 18:23 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1714176.Nme8cQ9zc4@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=keescook@google.com \
--cc=leozwang@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=xing.zheng@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox