* [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver
@ 2024-05-28 21:34 Tristram.Ha
2024-05-29 0:58 ` Andrew Lunn
2024-05-30 2:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Tristram.Ha @ 2024-05-28 21:34 UTC (permalink / raw)
To: Woojung Huh, Andrew Lunn, Vivien Didelot, Florian Fainelli,
Vladimir Oltean
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
UNGLinuxDriver, netdev, linux-kernel, Tristram Ha
From: Tristram Ha <tristram.ha@microchip.com>
The driver should return RMII interface when XMII is running in RMII mode.
Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Acked-by: Jerry Ray <jerry.ray@microchip.com>
---
drivers/net/dsa/microchip/ksz_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 1e0085cd9a9a..2818e24e2a51 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -3142,7 +3142,7 @@ phy_interface_t ksz_get_xmii(struct ksz_device *dev, int port, bool gbit)
else
interface = PHY_INTERFACE_MODE_MII;
} else if (val == bitval[P_RMII_SEL]) {
- interface = PHY_INTERFACE_MODE_RGMII;
+ interface = PHY_INTERFACE_MODE_RMII;
} else {
interface = PHY_INTERFACE_MODE_RGMII;
if (data8 & P_RGMII_ID_EG_ENABLE)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver
2024-05-28 21:34 [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver Tristram.Ha
@ 2024-05-29 0:58 ` Andrew Lunn
2024-05-30 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2024-05-29 0:58 UTC (permalink / raw)
To: Tristram.Ha
Cc: Woojung Huh, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
UNGLinuxDriver, netdev, linux-kernel
On Tue, May 28, 2024 at 02:34:26PM -0700, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
>
> The driver should return RMII interface when XMII is running in RMII mode.
>
> Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> Acked-by: Jerry Ray <jerry.ray@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver
2024-05-28 21:34 [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver Tristram.Ha
2024-05-29 0:58 ` Andrew Lunn
@ 2024-05-30 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-30 2:00 UTC (permalink / raw)
To: Tristram.Ha
Cc: woojung.huh, andrew, vivien.didelot, f.fainelli, olteanv, davem,
edumazet, kuba, pabeni, UNGLinuxDriver, netdev, linux-kernel,
tristram.ha
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 28 May 2024 14:34:26 -0700 you wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
>
> The driver should return RMII interface when XMII is running in RMII mode.
>
> Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> Acked-by: Jerry Ray <jerry.ray@microchip.com>
>
> [...]
Here is the summary with links:
- [net] net: dsa: microchip: fix RGMII error in KSZ DSA driver
https://git.kernel.org/netdev/net/c/278d65ccdadb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-30 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-28 21:34 [PATCH net] net: dsa: microchip: fix RGMII error in KSZ DSA driver Tristram.Ha
2024-05-29 0:58 ` Andrew Lunn
2024-05-30 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox