* [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()
@ 2024-05-30 5:17 Duoming Zhou
2024-05-30 5:23 ` Dan Carpenter
2024-06-01 23:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Duoming Zhou @ 2024-05-30 5:17 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, linux-hams, pabeni, kuba, edumazet, jreuter, davem,
dan.carpenter, Duoming Zhou
The object "ax25_dev" is managed by reference counting. Thus it should
not be directly released by kfree(), replace with ax25_dev_put().
Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
---
net/ax25/ax25_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ax25/ax25_dev.c b/net/ax25/ax25_dev.c
index 742d7c68e7e..9efd6690b34 100644
--- a/net/ax25/ax25_dev.c
+++ b/net/ax25/ax25_dev.c
@@ -196,7 +196,7 @@ void __exit ax25_dev_free(void)
list_for_each_entry_safe(s, n, &ax25_dev_list, list) {
netdev_put(s->dev, &s->dev_tracker);
list_del(&s->list);
- kfree(s);
+ ax25_dev_put(s);
}
spin_unlock_bh(&ax25_dev_lock);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()
2024-05-30 5:17 [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put() Duoming Zhou
@ 2024-05-30 5:23 ` Dan Carpenter
2024-06-01 23:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-05-30 5:23 UTC (permalink / raw)
To: Duoming Zhou
Cc: netdev, linux-kernel, linux-hams, pabeni, kuba, edumazet, jreuter,
davem
On Thu, May 30, 2024 at 01:17:33PM +0800, Duoming Zhou wrote:
> The object "ax25_dev" is managed by reference counting. Thus it should
> not be directly released by kfree(), replace with ax25_dev_put().
>
> Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()
2024-05-30 5:17 [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put() Duoming Zhou
2024-05-30 5:23 ` Dan Carpenter
@ 2024-06-01 23:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-01 23:00 UTC (permalink / raw)
To: Duoming Zhou
Cc: netdev, linux-kernel, linux-hams, pabeni, kuba, edumazet, jreuter,
davem, dan.carpenter
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 30 May 2024 13:17:33 +0800 you wrote:
> The object "ax25_dev" is managed by reference counting. Thus it should
> not be directly released by kfree(), replace with ax25_dev_put().
>
> Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
>
> [...]
Here is the summary with links:
- [net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()
https://git.kernel.org/netdev/net/c/166fcf86cd34
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-01 23:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30 5:17 [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put() Duoming Zhou
2024-05-30 5:23 ` Dan Carpenter
2024-06-01 23:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox