* [PATCH net-next] net: wangxun: use net_prefetch to simplify logic
@ 2024-07-29 15:26 Joe Damato
2024-07-30 10:16 ` Wojciech Drewek
2024-07-31 2:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Joe Damato @ 2024-07-29 15:26 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: Joe Damato, Jiawen Wu, Mengyuan Lou, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
Duanqiang Wen
Use net_prefetch to remove #ifdef and simplify prefetch logic. This
follows the pattern introduced in a previous commit f468f21b7af0 ("net:
Take common prefetch code structure into a function"), which replaced
the same logic in all existing drivers at that time.
Signed-off-by: Joe Damato <jdamato@fastly.com>
---
drivers/net/ethernet/wangxun/libwx/wx_lib.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
index 1eecba984f3b..2b3d6586f44a 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
@@ -251,10 +251,7 @@ static struct sk_buff *wx_build_skb(struct wx_ring *rx_ring,
rx_buffer->page_offset;
/* prefetch first cache line of first page */
- prefetch(page_addr);
-#if L1_CACHE_BYTES < 128
- prefetch(page_addr + L1_CACHE_BYTES);
-#endif
+ net_prefetch(page_addr);
/* allocate a skb to store the frags */
skb = napi_alloc_skb(&rx_ring->q_vector->napi, WX_RXBUFFER_256);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: wangxun: use net_prefetch to simplify logic
2024-07-29 15:26 [PATCH net-next] net: wangxun: use net_prefetch to simplify logic Joe Damato
@ 2024-07-30 10:16 ` Wojciech Drewek
2024-07-31 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Wojciech Drewek @ 2024-07-30 10:16 UTC (permalink / raw)
To: Joe Damato, linux-kernel, netdev
Cc: Jiawen Wu, Mengyuan Lou, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, Duanqiang Wen
On 29.07.2024 17:26, Joe Damato wrote:
> Use net_prefetch to remove #ifdef and simplify prefetch logic. This
> follows the pattern introduced in a previous commit f468f21b7af0 ("net:
> Take common prefetch code structure into a function"), which replaced
> the same logic in all existing drivers at that time.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> drivers/net/ethernet/wangxun/libwx/wx_lib.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> index 1eecba984f3b..2b3d6586f44a 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> @@ -251,10 +251,7 @@ static struct sk_buff *wx_build_skb(struct wx_ring *rx_ring,
> rx_buffer->page_offset;
>
> /* prefetch first cache line of first page */
> - prefetch(page_addr);
> -#if L1_CACHE_BYTES < 128
> - prefetch(page_addr + L1_CACHE_BYTES);
> -#endif
> + net_prefetch(page_addr);
>
> /* allocate a skb to store the frags */
> skb = napi_alloc_skb(&rx_ring->q_vector->napi, WX_RXBUFFER_256);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: wangxun: use net_prefetch to simplify logic
2024-07-29 15:26 [PATCH net-next] net: wangxun: use net_prefetch to simplify logic Joe Damato
2024-07-30 10:16 ` Wojciech Drewek
@ 2024-07-31 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-07-31 2:00 UTC (permalink / raw)
To: Joe Damato
Cc: linux-kernel, netdev, jiawenwu, mengyuanlou, davem, edumazet,
kuba, pabeni, horms, duanqiangwen
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 29 Jul 2024 15:26:47 +0000 you wrote:
> Use net_prefetch to remove #ifdef and simplify prefetch logic. This
> follows the pattern introduced in a previous commit f468f21b7af0 ("net:
> Take common prefetch code structure into a function"), which replaced
> the same logic in all existing drivers at that time.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
>
> [...]
Here is the summary with links:
- [net-next] net: wangxun: use net_prefetch to simplify logic
https://git.kernel.org/netdev/net-next/c/e832bc9e818c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-31 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-29 15:26 [PATCH net-next] net: wangxun: use net_prefetch to simplify logic Joe Damato
2024-07-30 10:16 ` Wojciech Drewek
2024-07-31 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox