public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 1/1] net: macb: increase max_mtu for oversized frames
@ 2024-08-12  9:06 vtpieter
  2024-08-16  2:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: vtpieter @ 2024-08-12  9:06 UTC (permalink / raw)
  To: Nicolas Ferre, Claudiu Beznea, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni
  Cc: Pieter Van Trappen, netdev, linux-kernel

From: Pieter Van Trappen <pieter.van.trappen@cern.ch>

Increase max_mtu from 1500 to 1518 bytes when not configured for jumbo
frames. Use 1536 as a starting point as documented in macb.h for
oversized (big) frames, which is the configuration applied in case
jumbo frames capability is not configured; ref. macb_main.c.

Signed-off-by: Pieter Van Trappen <pieter.van.trappen@cern.ch>
---
 drivers/net/ethernet/cadence/macb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 95e8742dce1d..c46fce4a9175 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -5119,12 +5119,12 @@ static int macb_probe(struct platform_device *pdev)
 		goto err_out_free_netdev;
 	}
 
-	/* MTU range: 68 - 1500 or 10240 */
+	/* MTU range: 68 - 1518 or 10240 */
 	dev->min_mtu = GEM_MTU_MIN_SIZE;
 	if ((bp->caps & MACB_CAPS_JUMBO) && bp->jumbo_max_len)
 		dev->max_mtu = bp->jumbo_max_len - ETH_HLEN - ETH_FCS_LEN;
 	else
-		dev->max_mtu = ETH_DATA_LEN;
+		dev->max_mtu = 1536 - ETH_HLEN - ETH_FCS_LEN;
 
 	if (bp->caps & MACB_CAPS_BD_RD_PREFETCH) {
 		val = GEM_BFEXT(RXBD_RDBUFF, gem_readl(bp, DCFG10));

base-commit: c4e82c025b3f2561823b4ba7c5f112a2005f442b
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next 1/1] net: macb: increase max_mtu for oversized frames
  2024-08-12  9:06 [PATCH net-next 1/1] net: macb: increase max_mtu for oversized frames vtpieter
@ 2024-08-16  2:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-16  2:10 UTC (permalink / raw)
  To: Pieter
  Cc: nicolas.ferre, claudiu.beznea, davem, edumazet, kuba, pabeni,
	pieter.van.trappen, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 12 Aug 2024 11:06:55 +0200 you wrote:
> From: Pieter Van Trappen <pieter.van.trappen@cern.ch>
> 
> Increase max_mtu from 1500 to 1518 bytes when not configured for jumbo
> frames. Use 1536 as a starting point as documented in macb.h for
> oversized (big) frames, which is the configuration applied in case
> jumbo frames capability is not configured; ref. macb_main.c.
> 
> [...]

Here is the summary with links:
  - [net-next,1/1] net: macb: increase max_mtu for oversized frames
    https://git.kernel.org/netdev/net-next/c/7cb43579641d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-16  2:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12  9:06 [PATCH net-next 1/1] net: macb: increase max_mtu for oversized frames vtpieter
2024-08-16  2:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox