public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h
@ 2024-08-16 11:13 Neeraj Sanjay Kale
  2024-08-16 11:13 ` [PATCH v2 2/2] Bluetooth: btnxpuart: Add support for ISO packets Neeraj Sanjay Kale
  2024-08-19 15:00 ` [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Neeraj Sanjay Kale @ 2024-08-16 11:13 UTC (permalink / raw)
  To: marcel, luiz.dentz
  Cc: linux-bluetooth, linux-kernel, amitkumar.karwar, rohit.fule,
	neeraj.sanjaykale, sherry.sun, ziniu.wang_1, haibo.chen, LnxRevLi

This adds ISO packet support in h4_recv.h, which was created before ISO
packet handling was added to hci_h4.c and hci_uart.c

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
 drivers/bluetooth/h4_recv.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/bluetooth/h4_recv.h b/drivers/bluetooth/h4_recv.h
index 4f2c89742245..647d37ca4cdd 100644
--- a/drivers/bluetooth/h4_recv.h
+++ b/drivers/bluetooth/h4_recv.h
@@ -38,6 +38,13 @@ struct h4_recv_pkt {
 	.lsize = 1, \
 	.maxlen = HCI_MAX_EVENT_SIZE
 
+#define H4_RECV_ISO \
+	.type = HCI_ISODATA_PKT, \
+	.hlen = HCI_ISO_HDR_SIZE, \
+	.loff = 2, \
+	.lsize = 2, \
+	.maxlen = HCI_MAX_FRAME_SIZE
+
 static inline struct sk_buff *h4_recv_buf(struct hci_dev *hdev,
 					  struct sk_buff *skb,
 					  const unsigned char *buffer,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] Bluetooth: btnxpuart: Add support for ISO packets
  2024-08-16 11:13 [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h Neeraj Sanjay Kale
@ 2024-08-16 11:13 ` Neeraj Sanjay Kale
  2024-08-19 15:00 ` [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: Neeraj Sanjay Kale @ 2024-08-16 11:13 UTC (permalink / raw)
  To: marcel, luiz.dentz
  Cc: linux-bluetooth, linux-kernel, amitkumar.karwar, rohit.fule,
	neeraj.sanjaykale, sherry.sun, ziniu.wang_1, haibo.chen, LnxRevLi

This enables btnxpuart driver to handle ISO RX packet when DUT is
configured as audio sink.

Tested IW612 on iMX8MMini platform and BlueZ-5.77 as follows:
1) Configured DUT with bap_bcast_sink role in pipewire configuration file.
2) Started pipewire and DUT is able to sync with Broadcast source through
pipewire.
3) ISO data RX is seen in btmon.
4) Audio/Music is heard on audio jack.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Tested-by: Sarveshwar Bajaj <sarveshwar.bajaj@nxp.com>
---
v2: Add test steps to commit message. (Paul Menzel)
---
 drivers/bluetooth/btnxpuart.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index f75b24bd3045..0b52e5505687 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1396,6 +1396,7 @@ static const struct h4_recv_pkt nxp_recv_pkts[] = {
 	{ H4_RECV_ACL,          .recv = hci_recv_frame },
 	{ H4_RECV_SCO,          .recv = hci_recv_frame },
 	{ H4_RECV_EVENT,        .recv = hci_recv_frame },
+	{ H4_RECV_ISO,		.recv = hci_recv_frame },
 	{ NXP_RECV_CHIP_VER_V1, .recv = nxp_recv_chip_ver_v1 },
 	{ NXP_RECV_FW_REQ_V1,   .recv = nxp_recv_fw_req_v1 },
 	{ NXP_RECV_CHIP_VER_V3, .recv = nxp_recv_chip_ver_v3 },
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h
  2024-08-16 11:13 [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h Neeraj Sanjay Kale
  2024-08-16 11:13 ` [PATCH v2 2/2] Bluetooth: btnxpuart: Add support for ISO packets Neeraj Sanjay Kale
@ 2024-08-19 15:00 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2024-08-19 15:00 UTC (permalink / raw)
  To: Neeraj Sanjay Kale
  Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel,
	amitkumar.karwar, rohit.fule, sherry.sun, ziniu.wang_1,
	haibo.chen, LnxRevLi

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 16 Aug 2024 16:43:08 +0530 you wrote:
> This adds ISO packet support in h4_recv.h, which was created before ISO
> packet handling was added to hci_h4.c and hci_uart.c
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
>  drivers/bluetooth/h4_recv.h | 7 +++++++
>  1 file changed, 7 insertions(+)

Here is the summary with links:
  - [v2,1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h
    https://git.kernel.org/bluetooth/bluetooth-next/c/ed5b740a347a
  - [v2,2/2] Bluetooth: btnxpuart: Add support for ISO packets
    https://git.kernel.org/bluetooth/bluetooth-next/c/da58f871fa89

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-19 15:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16 11:13 [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h Neeraj Sanjay Kale
2024-08-16 11:13 ` [PATCH v2 2/2] Bluetooth: btnxpuart: Add support for ISO packets Neeraj Sanjay Kale
2024-08-19 15:00 ` [PATCH v2 1/2] Bluetooth: hci_h4: Add support for ISO packets in h4_recv.h patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox