* [PATCH v2 net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code
@ 2024-09-28 10:04 Dan Carpenter
2024-10-03 0:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-09-28 10:04 UTC (permalink / raw)
To: Roger Quadros
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Julien Panis, Dan Carpenter, Alexander Sverdlin,
Grygorii Strashko, Chintan Vankar, Simon Horman, netdev,
linux-kernel, kernel-janitors
This error handling has a typo. It should i++ instead of i--. In the
original code the error handling will loop until it crashes.
Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
---
v2: The first version of this patch had white space corruption and didn't apply.
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index cbe99017cbfa..d253727b160f 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -763,7 +763,7 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
k3_udma_glue_disable_rx_chn(rx_chn->rx_chn);
fail_rx:
- for (i = 0; i < common->rx_ch_num_flows; i--)
+ for (i = 0; i < common->rx_ch_num_flows; i++)
k3_udma_glue_reset_rx_chn(rx_chn->rx_chn, i, &rx_chn->flows[i],
am65_cpsw_nuss_rx_cleanup, 0);
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code
2024-09-28 10:04 [PATCH v2 net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code Dan Carpenter
@ 2024-10-03 0:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-03 0:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: rogerq, davem, edumazet, kuba, pabeni, jpanis, alexander.sverdlin,
grygorii.strashko, c-vankar, horms, netdev, linux-kernel,
kernel-janitors
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 28 Sep 2024 13:04:01 +0300 you wrote:
> This error handling has a typo. It should i++ instead of i--. In the
> original code the error handling will loop until it crashes.
>
> Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
>
> [...]
Here is the summary with links:
- [v2,net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code
https://git.kernel.org/netdev/net/c/3c97fe4f9fbc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-03 0:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-28 10:04 [PATCH v2 net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code Dan Carpenter
2024-10-03 0:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox