* [PATCH] mctp i2c: drop check because i2c_unregister_device() is NULL safe
@ 2024-12-02 8:27 Wolfram Sang
2024-12-03 11:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2024-12-02 8:27 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Jeremy Kerr, Matt Johnston, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
No need to check the argument of i2c_unregister_device() because the
function itself does it.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. Please apply to your tree.
drivers/net/mctp/mctp-i2c.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/mctp/mctp-i2c.c b/drivers/net/mctp/mctp-i2c.c
index d2b3f5a59141..e3dcdeacc12c 100644
--- a/drivers/net/mctp/mctp-i2c.c
+++ b/drivers/net/mctp/mctp-i2c.c
@@ -177,8 +177,7 @@ static struct mctp_i2c_client *mctp_i2c_new_client(struct i2c_client *client)
return mcli;
err:
if (mcli) {
- if (mcli->client)
- i2c_unregister_device(mcli->client);
+ i2c_unregister_device(mcli->client);
kfree(mcli);
}
return ERR_PTR(rc);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mctp i2c: drop check because i2c_unregister_device() is NULL safe
2024-12-02 8:27 [PATCH] mctp i2c: drop check because i2c_unregister_device() is NULL safe Wolfram Sang
@ 2024-12-03 11:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-03 11:10 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, jk, matt, andrew+netdev, davem, edumazet, kuba,
pabeni, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 2 Dec 2024 09:27:13 +0100 you wrote:
> No need to check the argument of i2c_unregister_device() because the
> function itself does it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Build tested only. Please apply to your tree.
>
> [...]
Here is the summary with links:
- mctp i2c: drop check because i2c_unregister_device() is NULL safe
https://git.kernel.org/netdev/net-next/c/e8e7be7d212d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-03 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02 8:27 [PATCH] mctp i2c: drop check because i2c_unregister_device() is NULL safe Wolfram Sang
2024-12-03 11:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox