public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] dma: fix typo in the comment
@ 2024-09-18  3:41 Yan Zhen
  2024-10-07 12:25 ` Palmer Dabbelt
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yan Zhen @ 2024-09-18  3:41 UTC (permalink / raw)
  To: vkoul, paul.walmsley, samuel.holland, michal.simek
  Cc: dmaengine, linux-kernel, linux-riscv, linux-arm-kernel,
	opensource.kernel, Yan Zhen

Correctly spelled comments make it easier for the reader to understand
the code.

Replace 'enngine' with 'engine' in the comment &
replace 'trascatioin' with 'transaction' in the comment &
replace 'descripter' with 'descriptor' in the comment &
replace 'descritpor' with 'descriptor' in the comment &
replace 'rgisters' with 'registers' in the comment.

Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---
 drivers/dma/mv_xor_v2.c         | 2 +-
 drivers/dma/sf-pdma/sf-pdma.c   | 2 +-
 drivers/dma/sh/shdma-base.c     | 2 +-
 drivers/dma/sh/usb-dmac.c       | 2 +-
 drivers/dma/xilinx/zynqmp_dma.c | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index c8c67f4d982c..c6c9702dcca0 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -635,7 +635,7 @@ static int mv_xor_v2_descq_init(struct mv_xor_v2_device *xor_dev)
 	writel(MV_XOR_V2_DESC_NUM,
 	       xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_SIZE_OFF);
 
-	/* write the DESQ address to the DMA enngine*/
+	/* write the DESQ address to the DMA engine*/
 	writel(lower_32_bits(xor_dev->hw_desq),
 	       xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_BALR_OFF);
 	writel(upper_32_bits(xor_dev->hw_desq),
diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index 428473611115..538a7bc58108 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -354,7 +354,7 @@ static irqreturn_t sf_pdma_done_isr(int irq, void *dev_id)
 	if (!residue) {
 		tasklet_hi_schedule(&chan->done_tasklet);
 	} else {
-		/* submit next trascatioin if possible */
+		/* submit next transaction if possible */
 		struct sf_pdma_desc *desc = chan->desc;
 
 		desc->src_addr += desc->xfer_size - residue;
diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
index 588c5f409a80..fdd41e1c2263 100644
--- a/drivers/dma/sh/shdma-base.c
+++ b/drivers/dma/sh/shdma-base.c
@@ -961,7 +961,7 @@ void shdma_chan_probe(struct shdma_dev *sdev,
 
 	spin_lock_init(&schan->chan_lock);
 
-	/* Init descripter manage list */
+	/* Init descriptor manage list */
 	INIT_LIST_HEAD(&schan->ld_queue);
 	INIT_LIST_HEAD(&schan->ld_free);
 
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
index f7cd0cad056c..cc7f7ee7f74a 100644
--- a/drivers/dma/sh/usb-dmac.c
+++ b/drivers/dma/sh/usb-dmac.c
@@ -301,7 +301,7 @@ static struct usb_dmac_desc *usb_dmac_desc_get(struct usb_dmac_chan *chan,
 	struct usb_dmac_desc *desc = NULL;
 	unsigned long flags;
 
-	/* Get a freed descritpor */
+	/* Get a freed descriptor */
 	spin_lock_irqsave(&chan->vc.lock, flags);
 	list_for_each_entry(desc, &chan->desc_freed, node) {
 		if (sg_len <= desc->sg_allocated_len) {
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
index 9ae46f1198fe..18a407975e14 100644
--- a/drivers/dma/xilinx/zynqmp_dma.c
+++ b/drivers/dma/xilinx/zynqmp_dma.c
@@ -366,7 +366,7 @@ static void zynqmp_dma_init(struct zynqmp_dma_chan *chan)
 	}
 	writel(val, chan->regs + ZYNQMP_DMA_DATA_ATTR);
 
-	/* Clearing the interrupt account rgisters */
+	/* Clearing the interrupt account registers */
 	val = readl(chan->regs + ZYNQMP_DMA_IRQ_SRC_ACCT);
 	val = readl(chan->regs + ZYNQMP_DMA_IRQ_DST_ACCT);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] dma: fix typo in the comment
  2024-09-18  3:41 [PATCH v1] dma: fix typo in the comment Yan Zhen
@ 2024-10-07 12:25 ` Palmer Dabbelt
  2024-10-22  5:33 ` Vinod Koul
  2024-12-11 22:32 ` patchwork-bot+linux-riscv
  2 siblings, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2024-10-07 12:25 UTC (permalink / raw)
  To: yanzhen
  Cc: vkoul, Paul Walmsley, samuel.holland, michal.simek, dmaengine,
	linux-kernel, linux-riscv, linux-arm-kernel, opensource.kernel,
	yanzhen

On Tue, 17 Sep 2024 20:41:14 PDT (-0700), yanzhen@vivo.com wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
>
> Replace 'enngine' with 'engine' in the comment &
> replace 'trascatioin' with 'transaction' in the comment &
> replace 'descripter' with 'descriptor' in the comment &
> replace 'descritpor' with 'descriptor' in the comment &
> replace 'rgisters' with 'registers' in the comment.
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> ---
>  drivers/dma/mv_xor_v2.c         | 2 +-
>  drivers/dma/sf-pdma/sf-pdma.c   | 2 +-

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

for the SiFive stuff.  I'm happy to pick this up via the RISC-V tree if 
people want, but it's mostly for other stuff so I'm going to leave it 
alone for now.

Thanks!

>  drivers/dma/sh/shdma-base.c     | 2 +-
>  drivers/dma/sh/usb-dmac.c       | 2 +-
>  drivers/dma/xilinx/zynqmp_dma.c | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index c8c67f4d982c..c6c9702dcca0 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -635,7 +635,7 @@ static int mv_xor_v2_descq_init(struct mv_xor_v2_device *xor_dev)
>  	writel(MV_XOR_V2_DESC_NUM,
>  	       xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_SIZE_OFF);
>
> -	/* write the DESQ address to the DMA enngine*/
> +	/* write the DESQ address to the DMA engine*/
>  	writel(lower_32_bits(xor_dev->hw_desq),
>  	       xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_BALR_OFF);
>  	writel(upper_32_bits(xor_dev->hw_desq),
> diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
> index 428473611115..538a7bc58108 100644
> --- a/drivers/dma/sf-pdma/sf-pdma.c
> +++ b/drivers/dma/sf-pdma/sf-pdma.c
> @@ -354,7 +354,7 @@ static irqreturn_t sf_pdma_done_isr(int irq, void *dev_id)
>  	if (!residue) {
>  		tasklet_hi_schedule(&chan->done_tasklet);
>  	} else {
> -		/* submit next trascatioin if possible */
> +		/* submit next transaction if possible */
>  		struct sf_pdma_desc *desc = chan->desc;
>
>  		desc->src_addr += desc->xfer_size - residue;
> diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
> index 588c5f409a80..fdd41e1c2263 100644
> --- a/drivers/dma/sh/shdma-base.c
> +++ b/drivers/dma/sh/shdma-base.c
> @@ -961,7 +961,7 @@ void shdma_chan_probe(struct shdma_dev *sdev,
>
>  	spin_lock_init(&schan->chan_lock);
>
> -	/* Init descripter manage list */
> +	/* Init descriptor manage list */
>  	INIT_LIST_HEAD(&schan->ld_queue);
>  	INIT_LIST_HEAD(&schan->ld_free);
>
> diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
> index f7cd0cad056c..cc7f7ee7f74a 100644
> --- a/drivers/dma/sh/usb-dmac.c
> +++ b/drivers/dma/sh/usb-dmac.c
> @@ -301,7 +301,7 @@ static struct usb_dmac_desc *usb_dmac_desc_get(struct usb_dmac_chan *chan,
>  	struct usb_dmac_desc *desc = NULL;
>  	unsigned long flags;
>
> -	/* Get a freed descritpor */
> +	/* Get a freed descriptor */
>  	spin_lock_irqsave(&chan->vc.lock, flags);
>  	list_for_each_entry(desc, &chan->desc_freed, node) {
>  		if (sg_len <= desc->sg_allocated_len) {
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
> index 9ae46f1198fe..18a407975e14 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -366,7 +366,7 @@ static void zynqmp_dma_init(struct zynqmp_dma_chan *chan)
>  	}
>  	writel(val, chan->regs + ZYNQMP_DMA_DATA_ATTR);
>
> -	/* Clearing the interrupt account rgisters */
> +	/* Clearing the interrupt account registers */
>  	val = readl(chan->regs + ZYNQMP_DMA_IRQ_SRC_ACCT);
>  	val = readl(chan->regs + ZYNQMP_DMA_IRQ_DST_ACCT);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] dma: fix typo in the comment
  2024-09-18  3:41 [PATCH v1] dma: fix typo in the comment Yan Zhen
  2024-10-07 12:25 ` Palmer Dabbelt
@ 2024-10-22  5:33 ` Vinod Koul
  2024-12-11 22:32 ` patchwork-bot+linux-riscv
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2024-10-22  5:33 UTC (permalink / raw)
  To: paul.walmsley, samuel.holland, michal.simek, Yan Zhen
  Cc: dmaengine, linux-kernel, linux-riscv, linux-arm-kernel,
	opensource.kernel


On Wed, 18 Sep 2024 11:41:14 +0800, Yan Zhen wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
> 
> Replace 'enngine' with 'engine' in the comment &
> replace 'trascatioin' with 'transaction' in the comment &
> replace 'descripter' with 'descriptor' in the comment &
> replace 'descritpor' with 'descriptor' in the comment &
> replace 'rgisters' with 'registers' in the comment.
> 
> [...]

Applied, thanks!

[1/1] dma: fix typo in the comment
      commit: 39d283d146922a266e8196e7fd29b31feff528be

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] dma: fix typo in the comment
  2024-09-18  3:41 [PATCH v1] dma: fix typo in the comment Yan Zhen
  2024-10-07 12:25 ` Palmer Dabbelt
  2024-10-22  5:33 ` Vinod Koul
@ 2024-12-11 22:32 ` patchwork-bot+linux-riscv
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-12-11 22:32 UTC (permalink / raw)
  To: Yan Zhen
  Cc: linux-riscv, vkoul, paul.walmsley, samuel.holland, michal.simek,
	dmaengine, linux-kernel, linux-arm-kernel, opensource.kernel

Hello:

This patch was applied to riscv/linux.git (fixes)
by Vinod Koul <vkoul@kernel.org>:

On Wed, 18 Sep 2024 11:41:14 +0800 you wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
> 
> Replace 'enngine' with 'engine' in the comment &
> replace 'trascatioin' with 'transaction' in the comment &
> replace 'descripter' with 'descriptor' in the comment &
> replace 'descritpor' with 'descriptor' in the comment &
> replace 'rgisters' with 'registers' in the comment.
> 
> [...]

Here is the summary with links:
  - [v1] dma: fix typo in the comment
    https://git.kernel.org/riscv/c/39d283d14692

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-11 22:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18  3:41 [PATCH v1] dma: fix typo in the comment Yan Zhen
2024-10-07 12:25 ` Palmer Dabbelt
2024-10-22  5:33 ` Vinod Koul
2024-12-11 22:32 ` patchwork-bot+linux-riscv

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox