public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos
@ 2025-01-20  7:08 Yijie Yang
  2025-01-20  7:37 ` Krzysztof Kozlowski
  2025-01-23  4:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Yijie Yang @ 2025-01-20  7:08 UTC (permalink / raw)
  To: Vinod Koul, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: Krzysztof Kozlowski, netdev, linux-arm-msm, devicetree,
	linux-kernel, Yijie Yang

The qcs615-ride utilizes the same EMAC as the qcs404, rather than the
sm8150. The current incorrect fallback could result in packet loss.
The Ethernet on qcs615-ride is currently not utilized by anyone. Therefore,
there is no need to worry about any ABI impact.

Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615")
Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
Changes in v4:
- Update the base commit to next-20250117.
- Update the commit description for better clarity and understanding.
- Link to v3: https://lore.kernel.org/r/20250113-schema_qcs615-v3-1-d5bbf0ee8cb7@quicinc.com
---
 Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index f117471fb06fb3b507df811d55d41d0b610ac15f..e7ee0d9efed8330f5cf62e6c0ea41066572415aa 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -22,12 +22,12 @@ properties:
     oneOf:
       - items:
           - enum:
-              - qcom,qcs8300-ethqos
-          - const: qcom,sa8775p-ethqos
+              - qcom,qcs615-ethqos
+          - const: qcom,qcs404-ethqos
       - items:
           - enum:
-              - qcom,qcs615-ethqos
-          - const: qcom,sm8150-ethqos
+              - qcom,qcs8300-ethqos
+          - const: qcom,sa8775p-ethqos
       - enum:
           - qcom,qcs404-ethqos
           - qcom,sa8775p-ethqos

---
base-commit: 29ef83bb05764c31613d839f62474aa54b39e7d4
change-id: 20250113-schema_qcs615-bd7b3d82c2fa

Best regards,
-- 
Yijie Yang <quic_yijiyang@quicinc.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos
  2025-01-20  7:08 [PATCH v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos Yijie Yang
@ 2025-01-20  7:37 ` Krzysztof Kozlowski
  2025-01-23  4:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-20  7:37 UTC (permalink / raw)
  To: Yijie Yang
  Cc: Vinod Koul, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio, netdev,
	linux-arm-msm, devicetree, linux-kernel

On Mon, Jan 20, 2025 at 03:08:28PM +0800, Yijie Yang wrote:
> The qcs615-ride utilizes the same EMAC as the qcs404, rather than the
> sm8150. The current incorrect fallback could result in packet loss.
> The Ethernet on qcs615-ride is currently not utilized by anyone. Therefore,
> there is no need to worry about any ABI impact.
> 
> Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615")
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos
  2025-01-20  7:08 [PATCH v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos Yijie Yang
  2025-01-20  7:37 ` Krzysztof Kozlowski
@ 2025-01-23  4:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-01-23  4:10 UTC (permalink / raw)
  To: Yijie Yang
  Cc: vkoul, andrew+netdev, davem, edumazet, kuba, pabeni, robh,
	krzk+dt, conor+dt, andersson, konradybcio, krzysztof.kozlowski,
	netdev, linux-arm-msm, devicetree, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 20 Jan 2025 15:08:28 +0800 you wrote:
> The qcs615-ride utilizes the same EMAC as the qcs404, rather than the
> sm8150. The current incorrect fallback could result in packet loss.
> The Ethernet on qcs615-ride is currently not utilized by anyone. Therefore,
> there is no need to worry about any ABI impact.
> 
> Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615")
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> 
> [...]

Here is the summary with links:
  - [v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos
    https://git.kernel.org/netdev/net/c/ba1af257a057

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-01-23  4:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-20  7:08 [PATCH v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos Yijie Yang
2025-01-20  7:37 ` Krzysztof Kozlowski
2025-01-23  4:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox