[PATCH] Fix the __riscv_copy_vec_words_unaligned implementation

[PATCH] Fix the __riscv_copy_vec_words_unaligned implementation

[Tingbo Liao]

Correct the VEC_S macro definition to fix the implementation
of vector words copy in the case of unalignment in RISC-V.

Signed-off-by: Tingbo Liao <tingbo.liao@starfivetech.com>
---
 arch/riscv/kernel/vec-copy-unaligned.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/vec-copy-unaligned.S b/arch/riscv/kernel/vec-copy-unaligned.S
index d16f19f1b3b6..7ce4de6f6e69 100644
--- a/arch/riscv/kernel/vec-copy-unaligned.S
+++ b/arch/riscv/kernel/vec-copy-unaligned.S
@@ -11,7 +11,7 @@
 
 #define WORD_SEW CONCATENATE(e, WORD_EEW)
 #define VEC_L CONCATENATE(vle, WORD_EEW).v
-#define VEC_S CONCATENATE(vle, WORD_EEW).v
+#define VEC_S CONCATENATE(vse, WORD_EEW).v
 
 /* void __riscv_copy_vec_words_unaligned(void *, const void *, size_t) */
 /* Performs a memcpy without aligning buffers, using word loads and stores. */
-- 
2.46.0

Re: [PATCH] Fix the __riscv_copy_vec_words_unaligned implementation

[Alexandre Ghiti]

Hi Tingbo,

On 27/02/2025 08:27, Tingbo Liao wrote:
> Correct the VEC_S macro definition to fix the implementation
> of vector words copy in the case of unalignment in RISC-V.
>
> Signed-off-by: Tingbo Liao <tingbo.liao@starfivetech.com>
> ---
>   arch/riscv/kernel/vec-copy-unaligned.S | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/vec-copy-unaligned.S b/arch/riscv/kernel/vec-copy-unaligned.S
> index d16f19f1b3b6..7ce4de6f6e69 100644
> --- a/arch/riscv/kernel/vec-copy-unaligned.S
> +++ b/arch/riscv/kernel/vec-copy-unaligned.S
> @@ -11,7 +11,7 @@
>   
>   #define WORD_SEW CONCATENATE(e, WORD_EEW)
>   #define VEC_L CONCATENATE(vle, WORD_EEW).v
> -#define VEC_S CONCATENATE(vle, WORD_EEW).v
> +#define VEC_S CONCATENATE(vse, WORD_EEW).v
>   
>   /* void __riscv_copy_vec_words_unaligned(void *, const void *, size_t) */
>   /* Performs a memcpy without aligning buffers, using word loads and stores. */


That's a good catch, thanks.

However, your patch title should be prefixed with "riscv:" :

"[PATCH] riscv: Fix the __riscv_copy_vec_words_unaligned implementation"

And you miss the following Fixes tag:

Fixes: e7c9d66e313b ("RISC-V: Report vector unaligned access speed hwprobe")

And then you can add:

Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Can you respin a v2 with all those modifications please?

Thanks,

Alex

Re: [PATCH] Fix the __riscv_copy_vec_words_unaligned implementation

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (for-next)
by Alexandre Ghiti <alexghiti@rivosinc.com>:

On Wed, 26 Feb 2025 23:27:21 -0800 you wrote:
> Correct the VEC_S macro definition to fix the implementation
> of vector words copy in the case of unalignment in RISC-V.
> 
> Signed-off-by: Tingbo Liao <tingbo.liao@starfivetech.com>
> ---
>  arch/riscv/kernel/vec-copy-unaligned.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - Fix the __riscv_copy_vec_words_unaligned implementation
    https://git.kernel.org/riscv/c/475afa39b123

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html