From: Manivannan Sadhasivam <mani@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Arnd Bergmann <arnd@kernel.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Joyce Ooi <joyce.ooi@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: altera: remove unused 'node' variable
Date: Fri, 13 Jun 2025 14:55:28 +0530 [thread overview]
Message-ID: <174980672103.33830.4953083744774912018.b4-ty@kernel.org> (raw)
In-Reply-To: <20250521163329.2137973-1-arnd@kernel.org>
On Wed, 21 May 2025 18:29:48 +0200, Arnd Bergmann wrote:
> This variable is only used when CONFIG_OF is enabled:
>
> drivers/pci/controller/pcie-altera.c: In function 'altera_pcie_init_irq_domain':
> drivers/pci/controller/pcie-altera.c:855:29: error: unused variable 'node' [-Werror=unused-variable]
> 855 | struct device_node *node = dev->of_node;
>
> Use dev_fwnode() in place of of_node_to_fwnode() to avoid this.
>
> [...]
Applied, thanks!
[1/1] pci: altera: remove unused 'node' variable
commit: 693594d0e5d8d236fc4172c864afdcbe6993a2bd
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
next prev parent reply other threads:[~2025-06-13 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 16:29 [PATCH] pci: altera: remove unused 'node' variable Arnd Bergmann
2025-05-22 1:48 ` Hans Zhang
2025-05-22 5:53 ` Jiri Slaby
2025-05-22 6:32 ` Arnd Bergmann
2025-05-23 16:33 ` Bjorn Helgaas
2025-06-13 9:25 ` Manivannan Sadhasivam [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-06-11 10:43 [PATCH] mfd: fix building without CONFIG_OF Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] pci: altera: remove unused 'node' variable Jiri Slaby (SUSE)
2025-06-13 15:41 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174980672103.33830.4953083744774912018.b4-ty@kernel.org \
--to=mani@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=jirislaby@kernel.org \
--cc=joyce.ooi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox