Re: [PATCH] pci: altera: remove unused 'node' variable

[Jiri Slaby <jirislaby@kernel.org>]

On 21. 05. 25, 18:29, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This variable is only used when CONFIG_OF is enabled:
> 
> drivers/pci/controller/pcie-altera.c: In function 'altera_pcie_init_irq_domain':
> drivers/pci/controller/pcie-altera.c:855:29: error: unused variable 'node' [-Werror=unused-variable]
>    855 |         struct device_node *node = dev->of_node;
> 
> Use dev_fwnode() in place of of_node_to_fwnode() to avoid this.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

Right, this reminds me that my dev_fwnode() patches (in my local queue 
-- they were supposed to be in v3) are not only cleanup, but also fix 
warnings.

I was thinking to send those after the merge window (so that I can route 
through subsys maintainers and not bother Thomas, as they touch many 
files [1]), but I will send them when I am back from a conf.

[1]
arch/powerpc/platforms/8xx/cpm1-ic.c
arch/powerpc/sysdev/fsl_msi.c
drivers/edac/altera_edac.c
drivers/gpio/gpio-brcmstb.c
drivers/gpio/gpio-davinci.c
drivers/gpio/gpio-em.c
drivers/gpio/gpio-grgpio.c
drivers/gpio/gpio-lpc18xx.c
drivers/gpio/gpio-mvebu.c
drivers/gpio/gpio-mxc.c
drivers/gpio/gpio-mxs.c
drivers/gpio/gpio-pxa.c
drivers/gpio/gpio-rockchip.c
drivers/gpio/gpio-sodaville.c
drivers/gpio/gpio-tb10x.c
drivers/gpio/gpio-twl4030.c
drivers/gpu/drm/msm/msm_mdss.c
drivers/gpu/ipu-v3/ipu-common.c
drivers/i2c/muxes/i2c-mux-pca954x.c
drivers/iio/adc/stm32-adc-core.c
drivers/irqchip/irq-imgpdc.c
drivers/irqchip/irq-imx-irqsteer.c
drivers/irqchip/irq-keystone.c
drivers/irqchip/irq-mvebu-pic.c
drivers/irqchip/irq-pruss-intc.c
drivers/irqchip/irq-renesas-intc-irqpin.c
drivers/irqchip/irq-renesas-irqc.c
drivers/irqchip/irq-renesas-rza1.c
drivers/irqchip/irq-renesas-rzg2l.c
drivers/irqchip/irq-renesas-rzv2h.c
drivers/irqchip/irq-stm32mp-exti.c
drivers/irqchip/irq-ti-sci-inta.c
drivers/irqchip/irq-ti-sci-intr.c
drivers/irqchip/irq-ts4800.c
drivers/mailbox/qcom-ipcc.c
drivers/memory/omap-gpmc.c
drivers/mfd/88pm860x-core.c
drivers/mfd/ab8500-core.c
drivers/mfd/fsl-imx25-tsadc.c
drivers/mfd/lp8788-irq.c
drivers/mfd/max8925-core.c
drivers/mfd/mt6358-irq.c
drivers/mfd/mt6397-irq.c
drivers/mfd/qcom-pm8xxx.c
drivers/mfd/stmfx.c
drivers/mfd/tps65217.c
drivers/mfd/tps6586x.c
drivers/mfd/twl4030-irq.c
drivers/mfd/twl6030-irq.c
drivers/mfd/wm831x-irq.c
drivers/misc/hi6421v600-irq.c
drivers/net/dsa/microchip/ksz_common.c
drivers/net/dsa/microchip/ksz_ptp.c
drivers/net/dsa/mv88e6xxx/global2.c
drivers/net/dsa/qca/ar9331.c
drivers/net/usb/lan78xx.c
drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
drivers/pci/controller/pcie-altera.c
drivers/pci/controller/pcie-mediatek-gen3.c
drivers/pinctrl/mediatek/mtk-eint.c
drivers/pinctrl/pinctrl-at91-pio4.c
drivers/pinctrl/sunxi/pinctrl-sunxi.c
drivers/soc/fsl/qe/qe_ic.c
drivers/soc/tegra/pmc.c
drivers/thermal/qcom/lmh.c
drivers/thermal/tegra/soctherm.c


> Fixes: bbc94e6f72f2 ("PCI: Switch to irq_domain_create_linear()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> I checked the other PCI host bridge drivers as well, this is the
> only one with that problem.
> ---
>   drivers/pci/controller/pcie-altera.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
> index 0fc77176a52e..3dbb7adc421c 100644
> --- a/drivers/pci/controller/pcie-altera.c
> +++ b/drivers/pci/controller/pcie-altera.c
> @@ -852,10 +852,9 @@ static void aglx_isr(struct irq_desc *desc)
>   static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
>   {
>   	struct device *dev = &pcie->pdev->dev;
> -	struct device_node *node = dev->of_node;
>   
>   	/* Setup INTx */
> -	pcie->irq_domain = irq_domain_create_linear(of_fwnode_handle(node), PCI_NUM_INTX,
> +	pcie->irq_domain = irq_domain_create_linear(dev_fwnode(dev), PCI_NUM_INTX,
>   					&intx_domain_ops, pcie);
>   	if (!pcie->irq_domain) {
>   		dev_err(dev, "Failed to get a INTx IRQ domain\n");

thanks,
-- 
js
suse labs