The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btmtk: Fix wait_on_bit_timeout interruption during shutdown
@ 2025-07-24  8:51 Jiande Lu
  2025-08-01 16:10 ` patchwork-bot+bluetooth
  0 siblings, 1 reply; 2+ messages in thread
From: Jiande Lu @ 2025-07-24  8:51 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, Luiz Von Dentz
  Cc: Sean Wang, Chris Lu, Will Lee, SS Wu, Steve Lee, linux-bluetooth,
	linux-kernel, linux-mediatek, Jiande Lu

During the shutdown process, an interrupt occurs that
prematurely terminates the wait for the expected event.
This change replaces TASK_INTERRUPTIBLE with
TASK_UNINTERRUPTIBLE in the wait_on_bit_timeout call to ensure
the shutdown process completes as intended without being
interrupted by signals.

Fixes: d019930b0049 ("Bluetooth: btmtk: move btusb_mtk_hci_wmt_sync to btmtk.c")
Signed-off-by: Jiande Lu <jiande.lu@mediatek.com>
---
 drivers/bluetooth/btmtk.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
index 4390fd571dbd..a8c520dc09e1 100644
--- a/drivers/bluetooth/btmtk.c
+++ b/drivers/bluetooth/btmtk.c
@@ -642,12 +642,7 @@ static int btmtk_usb_hci_wmt_sync(struct hci_dev *hdev,
 	 * WMT command.
 	 */
 	err = wait_on_bit_timeout(&data->flags, BTMTK_TX_WAIT_VND_EVT,
-				  TASK_INTERRUPTIBLE, HCI_INIT_TIMEOUT);
-	if (err == -EINTR) {
-		bt_dev_err(hdev, "Execution of wmt command interrupted");
-		clear_bit(BTMTK_TX_WAIT_VND_EVT, &data->flags);
-		goto err_free_wc;
-	}
+				  TASK_UNINTERRUPTIBLE, HCI_INIT_TIMEOUT);
 
 	if (err) {
 		bt_dev_err(hdev, "Execution of wmt command timed out");
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: btmtk: Fix wait_on_bit_timeout interruption during shutdown
  2025-07-24  8:51 [PATCH] Bluetooth: btmtk: Fix wait_on_bit_timeout interruption during shutdown Jiande Lu
@ 2025-08-01 16:10 ` patchwork-bot+bluetooth
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+bluetooth @ 2025-08-01 16:10 UTC (permalink / raw)
  To: Jiande Lu
  Cc: marcel, johan.hedberg, luiz.dentz, sean.wang, chris.lu,
	will-cy.lee, ss.wu, steve.lee, linux-bluetooth, linux-kernel,
	linux-mediatek

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 24 Jul 2025 16:51:17 +0800 you wrote:
> During the shutdown process, an interrupt occurs that
> prematurely terminates the wait for the expected event.
> This change replaces TASK_INTERRUPTIBLE with
> TASK_UNINTERRUPTIBLE in the wait_on_bit_timeout call to ensure
> the shutdown process completes as intended without being
> interrupted by signals.
> 
> [...]

Here is the summary with links:
  - Bluetooth: btmtk: Fix wait_on_bit_timeout interruption during shutdown
    https://git.kernel.org/bluetooth/bluetooth-next/c/5ecd1fbdacce

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-01 16:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-24  8:51 [PATCH] Bluetooth: btmtk: Fix wait_on_bit_timeout interruption during shutdown Jiande Lu
2025-08-01 16:10 ` patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox