public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
@ 2025-11-03  7:20 Yue Haibing
  2025-11-03 17:16 ` Stanislav Fomichev
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yue Haibing @ 2025-11-03  7:20 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, horms, almasrymina
  Cc: netdev, linux-kernel, yuehaibing

Commit bd61848900bf ("net: devmem: Implement TX path") declared this
but never implemented it.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/core/devmem.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/devmem.h b/net/core/devmem.h
index 101150d761af..0b43a648cd2e 100644
--- a/net/core/devmem.h
+++ b/net/core/devmem.h
@@ -94,7 +94,6 @@ void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding);
 int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx,
 				    struct net_devmem_dmabuf_binding *binding,
 				    struct netlink_ext_ack *extack);
-void net_devmem_bind_tx_release(struct sock *sk);
 
 static inline struct dmabuf_genpool_chunk_owner *
 net_devmem_iov_to_chunk_owner(const struct net_iov *niov)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
  2025-11-03  7:20 [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release() Yue Haibing
@ 2025-11-03 17:16 ` Stanislav Fomichev
  2025-11-03 17:37 ` Mina Almasry
  2025-11-05  1:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Stanislav Fomichev @ 2025-11-03 17:16 UTC (permalink / raw)
  To: Yue Haibing
  Cc: davem, edumazet, kuba, pabeni, horms, almasrymina, netdev,
	linux-kernel

On 11/03, Yue Haibing wrote:
> Commit bd61848900bf ("net: devmem: Implement TX path") declared this
> but never implemented it.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Looks good, net_devmem_bind_tx_release was never used/implemented.

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
  2025-11-03  7:20 [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release() Yue Haibing
  2025-11-03 17:16 ` Stanislav Fomichev
@ 2025-11-03 17:37 ` Mina Almasry
  2025-11-05  1:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Mina Almasry @ 2025-11-03 17:37 UTC (permalink / raw)
  To: Yue Haibing; +Cc: davem, edumazet, kuba, pabeni, horms, netdev, linux-kernel

On Sun, Nov 2, 2025 at 10:58 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> Commit bd61848900bf ("net: devmem: Implement TX path") declared this
> but never implemented it.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Thank you.

Reviewed-by: Mina Almasry <almasrymina@google.com>

I thought about asking for a fixes tag, but this seems trivial enough
that it does not need to be backported to stable or anything.

-- 
Thanks,
Mina

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
  2025-11-03  7:20 [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release() Yue Haibing
  2025-11-03 17:16 ` Stanislav Fomichev
  2025-11-03 17:37 ` Mina Almasry
@ 2025-11-05  1:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-05  1:50 UTC (permalink / raw)
  To: Yue Haibing
  Cc: davem, edumazet, kuba, pabeni, horms, almasrymina, netdev,
	linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 3 Nov 2025 15:20:46 +0800 you wrote:
> Commit bd61848900bf ("net: devmem: Implement TX path") declared this
> but never implemented it.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  net/core/devmem.h | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release()
    https://git.kernel.org/netdev/net-next/c/f2143e283c6b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-11-05  1:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-03  7:20 [PATCH net-next] net: devmem: Remove unused declaration net_devmem_bind_tx_release() Yue Haibing
2025-11-03 17:16 ` Stanislav Fomichev
2025-11-03 17:37 ` Mina Almasry
2025-11-05  1:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox