[PATCH] Bluetooth: hci_event: fix memset typo

[PATCH] Bluetooth: hci_event: fix memset typo

[Jann Horn]

hci_le_big_sync_established_evt() currently does:

    conn->num_bis = 0;
    memset(conn->bis, 0, sizeof(conn->num_bis));

sizeof(conn->num_bis) is wrong - it would make sense to either use
conn->num_bis (before setting that to 0) or sizeof(conn->bis).
Fix it by using sizeof(conn->bis), the least intrusive change.

Luckily, nothing actually depends on this memset() working properly:
Nothing seems to ever read from conn->bis beyond conn->num_bis, and when
conn->num_bis is increased, the corresponding elements of conn->bis are
initialized. So I think this line could also just be removed.

This is a purely theoretical fix and should have no impact on actual
behavior.

Fixes: 42ecf1947135 ("Bluetooth: ISO: Do not emit LE BIG Create Sync if previous is pending")
Signed-off-by: Jann Horn <jannh@google.com>
---
compile-tested only
---
 net/bluetooth/hci_event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index b2ee6b6a0f56..ad3945e4fe2a 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -7168,7 +7168,7 @@ static void hci_le_big_sync_established_evt(struct hci_dev *hdev, void *data,
 	clear_bit(HCI_CONN_CREATE_BIG_SYNC, &conn->flags);
 
 	conn->num_bis = 0;
-	memset(conn->bis, 0, sizeof(conn->num_bis));
+	memset(conn->bis, 0, sizeof(conn->bis));
 
 	for (i = 0; i < ev->num_bis; i++) {
 		u16 handle = le16_to_cpu(ev->bis[i]);

---
base-commit: dca922e019dd758b4c1b4bec8f1d509efddeaab4
change-id: 20260429-bluetooth-memset-fix-01d70ce0acf7

--  
Jann Horn <jannh@google.com>

Re: [PATCH] Bluetooth: hci_event: fix memset typo

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 29 Apr 2026 15:40:46 +0200 you wrote:
> hci_le_big_sync_established_evt() currently does:
> 
>     conn->num_bis = 0;
>     memset(conn->bis, 0, sizeof(conn->num_bis));
> 
> sizeof(conn->num_bis) is wrong - it would make sense to either use
> conn->num_bis (before setting that to 0) or sizeof(conn->bis).
> Fix it by using sizeof(conn->bis), the least intrusive change.
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_event: fix memset typo
    https://git.kernel.org/bluetooth/bluetooth-next/c/bed1ff8e28fc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html