Re: [PATCH v5 2/2] platform/x86: x86-android-tablets: enable fwnode matching of GPIO chips

Re: [PATCH v5 2/2] platform/x86: x86-android-tablets: enable fwnode matching of GPIO chips

[Linus Walleij]

On Mon, May 4, 2026 at 12:59 PM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:

> In order to allow GPIOLIB to match cherryview and baytrail GPIO
> controllers by their firmware nodes instead of their names, we need to
> attach the - currently "dangling" - existing software nodes to their
> target devices dynamically.
>
> The driver uses platform_create_bundle() and expects all required
> providers to be present before it itself is probed. We know the name of
> the device we're waiting for so look them up and assign the appropriate
> software node as the secondary firmware node of the underlying ACPI node.
>
> Scheduling fine-grained devres actions allows for proper teardown and
> unsetting of the secondary firmware nodes.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Nice work here Bartosz!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH v5 0/2] platform/x86: x86-android-tablets: use real firmware node references with intel drivers

[Ilpo Järvinen]

On Mon, 04 May 2026 12:58:55 +0200, Bartosz Golaszewski wrote:

> First let me repeat the problem statement:
> 
> ==
> 
> GPIO software node lookup should rely exclusively on matching the
> addresses of the referenced firmware nodes. I tried to enforce it with
> commit e5d527be7e69 ("gpio: swnode: don't use the swnode's name as the
> key for GPIO lookup") but it broke existing users who abuse the software
> node mechanism by creating "dummy" software nodes named after the device
> they want to get GPIOs from but never attaching them to the actual GPIO
> devices. They rely on the current behavior of GPIOLIB where it will match
> the label of the GPIO controller against the name of the software node
> and does not require a true link.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/2] ACPI: provide acpi_bus_find_device_by_name()
      commit: 083a59e05db9203c346e87d822c0c12a0f7a7c85
[2/2] platform/x86: x86-android-tablets: enable fwnode matching of GPIO chips
      commit: 1448c2d2ca5cc7f4ea6694e6bc809946de0a751c

--
 i.