The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config
@ 2026-07-31 23:36 Bobby Eshleman
  2026-08-03 18:28 ` Mina Almasry
  2026-08-03 20:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Bobby Eshleman @ 2026-07-31 23:36 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Shuah Khan
  Cc: netdev, linux-kselftest, linux-kernel, bpf, Bobby Eshleman

From: Bobby Eshleman <bobbyeshleman@meta.com>

The config fragment already sets CONFIG_UDMABUF=y, but kconfig silently
drops it. UDMABUF/NET_DEVMEM both depend on DMA_SHARED_BUFFER, which we
can't enable directly, so we need to enable a config that selects it. We
use SYNC_FILE for that purpose here.

Additionally, we flip on CONFIG_NET_DEVMEM as well.

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
---
 tools/testing/selftests/drivers/net/hw/config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
index ed8642b68094..d89a9ba17655 100644
--- a/tools/testing/selftests/drivers/net/hw/config
+++ b/tools/testing/selftests/drivers/net/hw/config
@@ -15,11 +15,13 @@ CONFIG_IPV6_SIT=y
 CONFIG_IPV6_TUNNEL=y
 CONFIG_NET_CLS_ACT=y
 CONFIG_NET_CLS_BPF=y
+CONFIG_NET_DEVMEM=y
 CONFIG_NET_IPGRE=y
 CONFIG_NET_IPGRE_DEMUX=y
 CONFIG_NET_IPIP=y
 CONFIG_NETKIT=y
 CONFIG_NET_SCH_INGRESS=y
+CONFIG_SYNC_FILE=y
 CONFIG_UDMABUF=y
 CONFIG_USER_NS=y
 CONFIG_VXLAN=y

---
base-commit: 2fbade66245059c78daeaccfce13ecf499fffb51
change-id: 20260731-selftests-devmem-config-f4f843f0f0ad

Best regards,
-- 
Bobby Eshleman <bobbyeshleman@meta.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config
  2026-07-31 23:36 [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config Bobby Eshleman
@ 2026-08-03 18:28 ` Mina Almasry
  2026-08-03 20:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Mina Almasry @ 2026-08-03 18:28 UTC (permalink / raw)
  To: Bobby Eshleman
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Shuah Khan, netdev, linux-kselftest, linux-kernel,
	bpf, Bobby Eshleman

On Fri, Jul 31, 2026 at 4:38 PM Bobby Eshleman <bobbyeshleman@gmail.com> wrote:
>
> From: Bobby Eshleman <bobbyeshleman@meta.com>
>
> The config fragment already sets CONFIG_UDMABUF=y, but kconfig silently
> drops it. UDMABUF/NET_DEVMEM both depend on DMA_SHARED_BUFFER, which we
> can't enable directly, so we need to enable a config that selects it. We
> use SYNC_FILE for that purpose here.
>
> Additionally, we flip on CONFIG_NET_DEVMEM as well.
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>

While hacky, I think it's okay to find something that enables
DMA_SHARED_BUFFER for us here.

Reviewed-by: Mina Almasry <almasrymina@google.com>

> ---
>  tools/testing/selftests/drivers/net/hw/config | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
> index ed8642b68094..d89a9ba17655 100644
> --- a/tools/testing/selftests/drivers/net/hw/config
> +++ b/tools/testing/selftests/drivers/net/hw/config
> @@ -15,11 +15,13 @@ CONFIG_IPV6_SIT=y
>  CONFIG_IPV6_TUNNEL=y
>  CONFIG_NET_CLS_ACT=y
>  CONFIG_NET_CLS_BPF=y
> +CONFIG_NET_DEVMEM=y
>  CONFIG_NET_IPGRE=y
>  CONFIG_NET_IPGRE_DEMUX=y
>  CONFIG_NET_IPIP=y
>  CONFIG_NETKIT=y
>  CONFIG_NET_SCH_INGRESS=y
> +CONFIG_SYNC_FILE=y
>  CONFIG_UDMABUF=y
>  CONFIG_USER_NS=y
>  CONFIG_VXLAN=y
>
> ---
> base-commit: 2fbade66245059c78daeaccfce13ecf499fffb51
> change-id: 20260731-selftests-devmem-config-f4f843f0f0ad
>
> Best regards,
> --
> Bobby Eshleman <bobbyeshleman@meta.com>
>
>


-- 
Thanks,
Mina

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config
  2026-07-31 23:36 [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config Bobby Eshleman
  2026-08-03 18:28 ` Mina Almasry
@ 2026-08-03 20:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-08-03 20:30 UTC (permalink / raw)
  To: Bobby Eshleman
  Cc: andrew+netdev, davem, edumazet, kuba, pabeni, shuah, netdev,
	linux-kselftest, linux-kernel, bpf, bobbyeshleman

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 31 Jul 2026 16:36:23 -0700 you wrote:
> From: Bobby Eshleman <bobbyeshleman@meta.com>
> 
> The config fragment already sets CONFIG_UDMABUF=y, but kconfig silently
> drops it. UDMABUF/NET_DEVMEM both depend on DMA_SHARED_BUFFER, which we
> can't enable directly, so we need to enable a config that selects it. We
> use SYNC_FILE for that purpose here.
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: drv-net: enable devmem TCP in the test config
    https://git.kernel.org/netdev/net-next/c/8c7badd19e13

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-03 20:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-31 23:36 [PATCH net-next] selftests: drv-net: enable devmem TCP in the test config Bobby Eshleman
2026-08-03 18:28 ` Mina Almasry
2026-08-03 20:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox