* [PATCH] netlink: drop unneeded semicolon
@ 2026-08-01 19:09 Julia Lawall
2026-08-06 0:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2026-08-01 19:09 UTC (permalink / raw)
To: David S. Miller
Cc: kernel-janitors, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, netdev, linux-kernel
When a function-like macro expands to an expression, that expression
doesn't need a semicolon after it. All uses have been verified to
have their own semicolons.
This was found using the following Coccinelle semantic patch:
@r@
identifier i : script:ocaml() { String.lowercase_ascii i = i };
expression e;
@@
*#define i(...) e;
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
net/netlink/af_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 5202fe0b0..e6b1d9758 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -145,7 +145,7 @@ DEFINE_RWLOCK(nl_table_lock);
EXPORT_SYMBOL_GPL(nl_table_lock);
static atomic_t nl_table_users = ATOMIC_INIT(0);
-#define nl_deref_protected(X) rcu_dereference_protected(X, lockdep_is_held(&nl_table_lock));
+#define nl_deref_protected(X) rcu_dereference_protected(X, lockdep_is_held(&nl_table_lock))
static BLOCKING_NOTIFIER_HEAD(netlink_chain);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netlink: drop unneeded semicolon
2026-08-01 19:09 [PATCH] netlink: drop unneeded semicolon Julia Lawall
@ 2026-08-06 0:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-08-06 0:40 UTC (permalink / raw)
To: Julia Lawall
Cc: davem, kernel-janitors, edumazet, kuba, pabeni, horms, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 1 Aug 2026 21:09:56 +0200 you wrote:
> When a function-like macro expands to an expression, that expression
> doesn't need a semicolon after it. All uses have been verified to
> have their own semicolons.
>
> This was found using the following Coccinelle semantic patch:
>
> @r@
> identifier i : script:ocaml() { String.lowercase_ascii i = i };
> expression e;
> @@
>
> [...]
Here is the summary with links:
- netlink: drop unneeded semicolon
https://git.kernel.org/netdev/net-next/c/ced18ba79509
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-06 0:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-01 19:09 [PATCH] netlink: drop unneeded semicolon Julia Lawall
2026-08-06 0:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox