* [PATCH v2] ubifs: ubifs_dump_leb: remove return from end of void function
@ 2024-12-09 16:21 Pintu Kumar
2024-12-10 1:10 ` Zhihao Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Pintu Kumar @ 2024-12-09 16:21 UTC (permalink / raw)
To: richard, chengzhihao1, linux-mtd, linux-kernel
Cc: skhan, pintu.ping, Pintu Kumar
Noticed that there is a useless return statement at the end of void
function ubifs_dump_leb().
Just removed it.
Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
---
Changes in V2:
Change commit title as suggested by Zhihao Cheng.
V1: https://lore.kernel.org/all/e43da923-0184-d41e-a273-a02848f3b671@huawei.com/
---
fs/ubifs/debug.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 5cc69beaa62e..987eb5b6782a 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -863,7 +863,6 @@ void ubifs_dump_leb(const struct ubifs_info *c, int lnum)
out:
vfree(buf);
- return;
}
void ubifs_dump_znode(const struct ubifs_info *c,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ubifs: ubifs_dump_leb: remove return from end of void function
2024-12-09 16:21 [PATCH v2] ubifs: ubifs_dump_leb: remove return from end of void function Pintu Kumar
@ 2024-12-10 1:10 ` Zhihao Cheng
2025-01-03 9:41 ` Pintu Agarwal
0 siblings, 1 reply; 3+ messages in thread
From: Zhihao Cheng @ 2024-12-10 1:10 UTC (permalink / raw)
To: Pintu Kumar, richard, linux-mtd, linux-kernel; +Cc: skhan, pintu.ping
在 2024/12/10 0:21, Pintu Kumar 写道:
> Noticed that there is a useless return statement at the end of void
> function ubifs_dump_leb().
> Just removed it.
>
> Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
> Changes in V2:
> Change commit title as suggested by Zhihao Cheng.
> V1: https://lore.kernel.org/all/e43da923-0184-d41e-a273-a02848f3b671@huawei.com/
> ---
> fs/ubifs/debug.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
> index 5cc69beaa62e..987eb5b6782a 100644
> --- a/fs/ubifs/debug.c
> +++ b/fs/ubifs/debug.c
> @@ -863,7 +863,6 @@ void ubifs_dump_leb(const struct ubifs_info *c, int lnum)
>
> out:
> vfree(buf);
> - return;
> }
>
> void ubifs_dump_znode(const struct ubifs_info *c,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ubifs: ubifs_dump_leb: remove return from end of void function
2024-12-10 1:10 ` Zhihao Cheng
@ 2025-01-03 9:41 ` Pintu Agarwal
0 siblings, 0 replies; 3+ messages in thread
From: Pintu Agarwal @ 2025-01-03 9:41 UTC (permalink / raw)
To: Zhihao Cheng; +Cc: Pintu Kumar, richard, linux-mtd, linux-kernel, skhan
Hi,
On Tue, 10 Dec 2024 at 06:40, Zhihao Cheng <chengzhihao1@huawei.com> wrote:
>
> 在 2024/12/10 0:21, Pintu Kumar 写道:
> > Noticed that there is a useless return statement at the end of void
> > function ubifs_dump_leb().
> > Just removed it.
> >
> > Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
> >
>
> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Thank you so much for your review.
Just a reminder, I don't see these 2 patches getting picked.
Am I missing anything ?
Thanks,
Pintu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-03 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-09 16:21 [PATCH v2] ubifs: ubifs_dump_leb: remove return from end of void function Pintu Kumar
2024-12-10 1:10 ` Zhihao Cheng
2025-01-03 9:41 ` Pintu Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox