Re: [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote:
> From: Bo Kong <Bo.Kong@mediatek.com>
> 
> Add a V4L2 sub-device driver for MT8188 AIE.
> 
> Signed-off-by: Bo Kong <Bo.Kong@mediatek.com>
> ---

[snip]

> +static int mtk_aie_hw_connect(struct mtk_aie_dev *fd)
> +{
> +	if (mtk_aie_hw_enable(fd))
> +		return -EINVAL;

mtk_aie_hw_connect() just call mtk_aie_hw_enable(),
and mtk_aie_hw_enable() just print some message and call aie_init(),
so drop mtk_aie_hw_connect() and mtk_aie_hw_enable() and caller directly call aie_init().

> +
> +	return 0;
> +}
> +
> +static void mtk_aie_hw_disconnect(struct mtk_aie_dev *fd)
> +{
> +	aie_uninit(fd);

mtk_aie_hw_disconnect() just call aie_unnit(),
so drop mtk_aie_hw_disconnect() and caller directly call aie_uninit().

Regards,
CK

> +}
> +