public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"Bo Kong (孔波)" <Bo.Kong@mediatek.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver
Date: Thu, 26 Dec 2024 06:50:19 +0000	[thread overview]
Message-ID: <846d4676b106cdd6380b965cbde83d02f73f38c8.camel@mediatek.com> (raw)
In-Reply-To: <20241225090113.17027-4-bo.kong@mediatek.com>

On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote:
> From: Bo Kong <Bo.Kong@mediatek.com>
> 
> Add a V4L2 sub-device driver for MT8188 AIE.
> 
> Signed-off-by: Bo Kong <Bo.Kong@mediatek.com>
> ---

[snip]

> +static const struct mtk_aie_variant aie_31_drvdata = {
> +	.hw_version = 31,
> +	.fld_enable = 1,
> +	.y2r_cfg_size = 34,
> +	.rs_cfg_size = 30,
> +	.fd_cfg_size = 56,
> +};
> +

This is the first patch to add AIE driver.
So it's not necessary to create SoC data.
So drop hw_version and fld_enable.
Define symbol for others:

#define Y2R_CFG_SIZE 34
#define RS_CFG_SIZE 30
#define FD_CFG_SIZE 56

Regards,
CK



  parent reply	other threads:[~2024-12-26  6:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-25  9:00 [PATCH v3 0/4] Add AIE Driver bo.kong
2024-12-25  9:00 ` [PATCH v3 1/4] arm64: dts: mt8188: add aie node bo.kong
2024-12-25  9:00 ` [PATCH v3 2/4] media: dt-bindings: add MT8188 AIE bo.kong
2024-12-25 10:29   ` Rob Herring (Arm)
2024-12-25 11:28   ` Krzysztof Kozlowski
2024-12-26  3:41   ` CK Hu (胡俊光)
2024-12-25  9:00 ` [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver bo.kong
2024-12-25 11:35   ` Krzysztof Kozlowski
2024-12-26  3:53   ` CK Hu (胡俊光)
2024-12-26  5:20   ` CK Hu (胡俊光)
2024-12-26  5:36   ` CK Hu (胡俊光)
2024-12-26  6:09   ` CK Hu (胡俊光)
2024-12-26  6:50   ` CK Hu (胡俊光) [this message]
2024-12-26  7:38   ` CK Hu (胡俊光)
2024-12-27  3:23   ` CK Hu (胡俊光)
2024-12-27  3:54   ` CK Hu (胡俊光)
2024-12-27  5:56   ` CK Hu (胡俊光)
2024-12-27  6:05   ` CK Hu (胡俊光)
2024-12-31  7:45     ` Krzysztof Kozlowski
2024-12-31  7:57       ` CK Hu (胡俊光)
2024-12-31  8:07         ` Krzysztof Kozlowski
2024-12-31  8:13           ` CK Hu (胡俊光)
2024-12-30  7:39   ` CK Hu (胡俊光)
2025-01-07 15:32   ` AngeloGioacchino Del Regno
2024-12-25  9:00 ` [PATCH v3 4/4] uapi: linux: add MT8188 AIE bo.kong
2024-12-26  6:36   ` CK Hu (胡俊光)
2024-12-31  6:55   ` CK Hu (胡俊光)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=846d4676b106cdd6380b965cbde83d02f73f38c8.camel@mediatek.com \
    --to=ck.hu@mediatek.com \
    --cc=Bo.Kong@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox