* [PATCH] mshv: add a missing padding field
@ 2026-04-23 17:26 wei.liu
2026-04-23 17:29 ` Easwar Hariharan
0 siblings, 1 reply; 5+ messages in thread
From: wei.liu @ 2026-04-23 17:26 UTC (permalink / raw)
To: Linux on Hyper-V List
Cc: Wei Liu, Doru Blânzeanu, Magnus Kulke, stable,
K. Y. Srinivasan, Haiyang Zhang, Dexuan Cui, Long Li,
Nuno Das Neves, Roman Kisel, Michael Kelley, Easwar Hariharan,
open list
From: Wei Liu <wei.liu@kernel.org>
That was missed when importing the header.
Reported-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>
Reported-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
Fixes: e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")
Cc: stable@kernel.org
Signed-off-by: Wei Liu <wei.liu@kernel.org>
---
include/hyperv/hvhdk.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hyperv/hvhdk.h b/include/hyperv/hvhdk.h
index 5e83d3714966..ff7ca9ee1bd4 100644
--- a/include/hyperv/hvhdk.h
+++ b/include/hyperv/hvhdk.h
@@ -79,6 +79,7 @@ struct hv_vp_register_page {
u64 registers[18];
};
+ __u8 reserved[8];
/* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */
union {
struct {
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mshv: add a missing padding field
2026-04-23 17:26 [PATCH] mshv: add a missing padding field wei.liu
@ 2026-04-23 17:29 ` Easwar Hariharan
2026-04-23 17:32 ` Easwar Hariharan
0 siblings, 1 reply; 5+ messages in thread
From: Easwar Hariharan @ 2026-04-23 17:29 UTC (permalink / raw)
To: wei.liu
Cc: Linux on Hyper-V List, easwar.hariharan, Doru Blânzeanu,
Magnus Kulke, stable, K. Y. Srinivasan, Haiyang Zhang, Dexuan Cui,
Long Li, Nuno Das Neves, Roman Kisel, Michael Kelley, open list
On 4/23/2026 10:26 AM, wei.liu@kernel.org wrote:
> From: Wei Liu <wei.liu@kernel.org>
>
> That was missed when importing the header.
>
> Reported-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>
> Reported-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> Fixes: e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")
> Cc: stable@kernel.org
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
> include/hyperv/hvhdk.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/hyperv/hvhdk.h b/include/hyperv/hvhdk.h
> index 5e83d3714966..ff7ca9ee1bd4 100644
> --- a/include/hyperv/hvhdk.h
> +++ b/include/hyperv/hvhdk.h
> @@ -79,6 +79,7 @@ struct hv_vp_register_page {
>
> u64 registers[18];
> };
> + __u8 reserved[8];
> /* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */
> union {
> struct {
This is not a uapi, so why not just use u8 instead of __u8?
Or since it's 8 u8s, a u64?
Thanks,
Easwar (he/him)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mshv: add a missing padding field
2026-04-23 17:29 ` Easwar Hariharan
@ 2026-04-23 17:32 ` Easwar Hariharan
2026-04-23 18:14 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Easwar Hariharan @ 2026-04-23 17:32 UTC (permalink / raw)
To: wei.liu
Cc: easwar.hariharan, Linux on Hyper-V List, Doru Blânzeanu,
Magnus Kulke, stable, K. Y. Srinivasan, Haiyang Zhang, Dexuan Cui,
Long Li, Nuno Das Neves, Roman Kisel, Michael Kelley, open list
On 4/23/2026 10:29 AM, Easwar Hariharan wrote:
> On 4/23/2026 10:26 AM, wei.liu@kernel.org wrote:
>> From: Wei Liu <wei.liu@kernel.org>
>>
>> That was missed when importing the header.
>>
>> Reported-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>
>> Reported-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
>> Fixes: e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")
>> Cc: stable@kernel.org
>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
>> ---
>> include/hyperv/hvhdk.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/hyperv/hvhdk.h b/include/hyperv/hvhdk.h
>> index 5e83d3714966..ff7ca9ee1bd4 100644
>> --- a/include/hyperv/hvhdk.h
>> +++ b/include/hyperv/hvhdk.h
>> @@ -79,6 +79,7 @@ struct hv_vp_register_page {
>>
>> u64 registers[18];
>> };
>> + __u8 reserved[8];
>> /* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */
>> union {
>> struct {
>
>
> This is not a uapi, so why not just use u8 instead of __u8?
> Or since it's 8 u8s, a u64?
>
> Thanks,
> Easwar (he/him)
Hm, occurs to me that this would be used by VMMs, but then the registers
field just above used a u64 instead of a __u64....
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mshv: add a missing padding field
2026-04-23 17:32 ` Easwar Hariharan
@ 2026-04-23 18:14 ` Wei Liu
2026-04-23 18:16 ` Easwar Hariharan
0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2026-04-23 18:14 UTC (permalink / raw)
To: Easwar Hariharan
Cc: wei.liu, Linux on Hyper-V List, Doru Blânzeanu, Magnus Kulke,
stable, K. Y. Srinivasan, Haiyang Zhang, Dexuan Cui, Long Li,
Nuno Das Neves, Roman Kisel, Michael Kelley, open list
On Thu, Apr 23, 2026 at 10:32:58AM -0700, Easwar Hariharan wrote:
> On 4/23/2026 10:29 AM, Easwar Hariharan wrote:
> > On 4/23/2026 10:26 AM, wei.liu@kernel.org wrote:
> >> From: Wei Liu <wei.liu@kernel.org>
> >>
> >> That was missed when importing the header.
> >>
> >> Reported-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>
> >> Reported-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
> >> Fixes: e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")
> >> Cc: stable@kernel.org
> >> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> >> ---
> >> include/hyperv/hvhdk.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/include/hyperv/hvhdk.h b/include/hyperv/hvhdk.h
> >> index 5e83d3714966..ff7ca9ee1bd4 100644
> >> --- a/include/hyperv/hvhdk.h
> >> +++ b/include/hyperv/hvhdk.h
> >> @@ -79,6 +79,7 @@ struct hv_vp_register_page {
> >>
> >> u64 registers[18];
> >> };
> >> + __u8 reserved[8];
> >> /* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */
> >> union {
> >> struct {
> >
> >
> > This is not a uapi, so why not just use u8 instead of __u8?
> > Or since it's 8 u8s, a u64?
> >
> > Thanks,
> > Easwar (he/him)
>
> Hm, occurs to me that this would be used by VMMs, but then the registers
> field just above used a u64 instead of a __u64....
I fat-fingered u8 to __u8. User space code has scripts to massage the
types as needed.
To remain consistent with the existing code, it should be u8.
I can change the type when I commit this.
Wei
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mshv: add a missing padding field
2026-04-23 18:14 ` Wei Liu
@ 2026-04-23 18:16 ` Easwar Hariharan
0 siblings, 0 replies; 5+ messages in thread
From: Easwar Hariharan @ 2026-04-23 18:16 UTC (permalink / raw)
To: Wei Liu
Cc: easwar.hariharan, Linux on Hyper-V List, Doru Blânzeanu,
Magnus Kulke, stable, K. Y. Srinivasan, Haiyang Zhang, Dexuan Cui,
Long Li, Nuno Das Neves, Roman Kisel, Michael Kelley, open list
On 4/23/2026 11:14 AM, Wei Liu wrote:
> On Thu, Apr 23, 2026 at 10:32:58AM -0700, Easwar Hariharan wrote:
>> On 4/23/2026 10:29 AM, Easwar Hariharan wrote:
>>> On 4/23/2026 10:26 AM, wei.liu@kernel.org wrote:
>>>> From: Wei Liu <wei.liu@kernel.org>
>>>>
>>>> That was missed when importing the header.
>>>>
>>>> Reported-by: Doru Blânzeanu <dblanzeanu@linux.microsoft.com>
>>>> Reported-by: Magnus Kulke <magnuskulke@linux.microsoft.com>
>>>> Fixes: e68bda71a2384 ("hyperv: Add new Hyper-V headers in include/hyperv")
>>>> Cc: stable@kernel.org
>>>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
>>>> ---
>>>> include/hyperv/hvhdk.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/include/hyperv/hvhdk.h b/include/hyperv/hvhdk.h
>>>> index 5e83d3714966..ff7ca9ee1bd4 100644
>>>> --- a/include/hyperv/hvhdk.h
>>>> +++ b/include/hyperv/hvhdk.h
>>>> @@ -79,6 +79,7 @@ struct hv_vp_register_page {
>>>>
>>>> u64 registers[18];
>>>> };
>>>> + __u8 reserved[8];
>>>> /* Volatile XMM registers (HV_X64_REGISTER_CLASS_XMM) */
>>>> union {
>>>> struct {
>>>
>>>
>>> This is not a uapi, so why not just use u8 instead of __u8?
>>> Or since it's 8 u8s, a u64?
>>>
>>> Thanks,
>>> Easwar (he/him)
>>
>> Hm, occurs to me that this would be used by VMMs, but then the registers
>> field just above used a u64 instead of a __u64....
>
> I fat-fingered u8 to __u8. User space code has scripts to massage the
> types as needed.
>
> To remain consistent with the existing code, it should be u8.
>
> I can change the type when I commit this.
>
> Wei
Thanks, with that fixed:
Reviewed-by: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-23 18:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-23 17:26 [PATCH] mshv: add a missing padding field wei.liu
2026-04-23 17:29 ` Easwar Hariharan
2026-04-23 17:32 ` Easwar Hariharan
2026-04-23 18:14 ` Wei Liu
2026-04-23 18:16 ` Easwar Hariharan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox