From: "Chen, Yu C" <yu.c.chen@intel.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, <ricardo.neri@intel.com>,
Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
<linux-kernel@vger.kernel.org>,
Christian Loehle <christian.loehle@arm.com>,
Ben Segall <bsegall@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Tim C Chen <tim.c.chen@linux.intel.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
Barry Song <baohua@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3 2/4] sched/fair: Skip misfit load accounting when the destination CPU cannot help
Date: Fri, 15 May 2026 20:49:18 +0800 [thread overview]
Message-ID: <19c47ddd-2dfa-4584-b7bd-f5be06a9fea2@intel.com> (raw)
In-Reply-To: <20260514-rneri-fix-cas-clusters-v3-2-0037869554bd@linux.intel.com>
On 5/15/2026 2:34 AM, Ricardo Neri wrote:
> + if (rq->misfit_task_load) {
> + /*
> + * Always mark the domain overloaded so big CPUs
> + * can pick up misfit tasks via newly idle
> + * balance.
> + */
> *sg_overloaded = 1;
if (balancing_at_rd)
*sg_overloaded = 1
to avoid confusing non-root domain(although in current code only
root domain checks this)
But the original logic does not have this check, it should be OK.
Reviewed-by: Chen Yu <yu.c.chen@intel.com>
thanks,
Chenyu
next prev parent reply other threads:[~2026-05-15 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 18:34 [PATCH v3 0/4] sched: Fix cluster scheduling in the presence of asymmetric capacity Ricardo Neri
2026-05-14 18:34 ` [PATCH v3 1/4] sched/fair: Check CPU capacity before comparing group types during load balance Ricardo Neri
2026-05-15 12:29 ` Chen, Yu C
2026-05-15 19:26 ` Tim Chen
2026-05-14 18:34 ` [PATCH v3 2/4] sched/fair: Skip misfit load accounting when the destination CPU cannot help Ricardo Neri
2026-05-15 12:49 ` Chen, Yu C [this message]
2026-05-15 20:12 ` Tim Chen
2026-05-14 18:34 ` [PATCH v3 3/4] sched/fair: Allow load balancing between CPUs of identical capacity Ricardo Neri
2026-05-15 15:16 ` Chen, Yu C
2026-05-14 18:34 ` [PATCH v3 4/4] sched/topology: Do not clear SD_PREFER_SIBLING in domains with clusters Ricardo Neri
2026-05-15 20:21 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c47ddd-2dfa-4584-b7bd-f5be06a9fea2@intel.com \
--to=yu.c.chen@intel.com \
--cc=baohua@kernel.org \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox