From: Baolu Lu <baolu.lu@linux.intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, kevin.tian@intel.com, jgg@nvidia.com
Cc: baolu.lu@linux.intel.com, will@kernel.org, robin.murphy@arm.com,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
xueshuai@linux.alibaba.com
Subject: Re: [PATCH rc v8 1/8] iommu: Fix NULL group->domain dereference in pci_dev_reset_iommu_done()
Date: Mon, 27 Apr 2026 16:32:32 +0800 [thread overview]
Message-ID: <19cb7a81-9eb4-4792-a102-de94e008f4c7@linux.intel.com> (raw)
In-Reply-To: <c5bc84ee72651ce22b69bce3cb731a721a3d057a.1777074513.git.nicolinc@nvidia.com>
On 4/25/2026 9:15 AM, Nicolin Chen wrote:
> Local sashiko review pointed it out that group->domain could be NULL when
> a default domain fails to allocate during the first probe, which can crash
> at domain->ops->attach_dev dereference in __iommu_attach_device() invoked
> by pci_dev_reset_iommu_done().
>
> pci_dev_reset_iommu_prepare() is fine as an old_domain pointer can be NULL.
>
> Skip the re-attach in pci_dev_reset_iommu_done() to fix the bug.
>
> Fixes: c279e83953d9 ("iommu: Introduce pci_dev_reset_iommu_prepare/done()")
> Cc:stable@vger.kernel.org
> Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
> ---
> drivers/iommu/iommu.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
next prev parent reply other threads:[~2026-04-27 8:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 1:15 [PATCH rc v8 0/8] iommu: Fix pci_dev_reset_iommu_prepare/done() Nicolin Chen
2026-04-25 1:15 ` [PATCH rc v8 1/8] iommu: Fix NULL group->domain dereference in pci_dev_reset_iommu_done() Nicolin Chen
2026-04-27 8:32 ` Baolu Lu [this message]
2026-04-25 1:15 ` [PATCH rc v8 2/8] iommu: Fix kdocs of pci_dev_reset_iommu_done() Nicolin Chen
2026-04-25 1:15 ` [PATCH rc v8 3/8] iommu: Replace per-group resetting_domain with per-gdev blocked flag Nicolin Chen
2026-04-25 1:15 ` [PATCH rc v8 4/8] iommu: Fix pasid attach in pci_dev_reset_iommu_prepare/done() Nicolin Chen
2026-04-27 8:34 ` Baolu Lu
2026-04-25 1:15 ` [PATCH rc v8 5/8] iommu: Fix nested pci_dev_reset_iommu_prepare/done() Nicolin Chen
2026-04-25 1:15 ` [PATCH rc v8 6/8] iommu: Fix ATS invalidation timeouts during __iommu_remove_group_pasid() Nicolin Chen
2026-04-27 8:37 ` Baolu Lu
2026-04-25 1:15 ` [PATCH rc v8 7/8] iommu: Fix WARN_ON in __iommu_group_set_domain_nofail() due to reset Nicolin Chen
2026-04-25 1:15 ` [PATCH rc v8 8/8] iommu: Warn on premature unblock during DMA aliased sibling reset Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19cb7a81-9eb4-4792-a102-de94e008f4c7@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox