* [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' @ 2024-06-15 13:22 kernel test robot 2024-06-15 14:33 ` Borislav Petkov 2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov 0 siblings, 2 replies; 16+ messages in thread From: kernel test robot @ 2024-06-15 13:22 UTC (permalink / raw) To: Alexey Makhalov; +Cc: oe-kbuild-all, linux-kernel, x86, Borislav Petkov (AMD) tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vmware head: ef08e7dc21307b226b5280d5e8cfea687bfd2866 commit: e5ac9008b79c59235c34494e555419665022f5e1 [4/8] drm/vmwgfx: Use VMware hypercall API config: i386-buildonly-randconfig-002-20240615 (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/config) compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ All errors (new ones prefixed by >>): ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_open_channel.constprop.0': >> vmwgfx_msg.c:(.text+0x203): undefined reference to `vmware_hypercall_slow' ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_recv_msg': vmwgfx_msg.c:(.text+0x46f): undefined reference to `vmware_hypercall_slow' >> ld: vmwgfx_msg.c:(.text+0x49c): undefined reference to `vmware_hypercall_slow' ld: vmwgfx_msg.c:(.text+0x4c3): undefined reference to `vmware_hypercall_slow' ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_close_channel': vmwgfx_msg.c:(.text+0x580): undefined reference to `vmware_hypercall_slow' ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o:vmwgfx_msg.c:(.text+0x729): more undefined references to `vmware_hypercall_slow' follow ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write': regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync' ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0': regmap-spi.c:(.text+0x337): undefined reference to `spi_sync' ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write': regmap-spi.c:(.text+0x445): undefined reference to `spi_async' ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init': ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver' Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for REGMAP_SPI Depends on [n]: SPI [=n] Selected by [y]: - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y]) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' 2024-06-15 13:22 [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' kernel test robot @ 2024-06-15 14:33 ` Borislav Petkov 2024-06-15 20:41 ` Alexey Makhalov 2024-06-15 21:41 ` Alexey Makhalov 2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov 1 sibling, 2 replies; 16+ messages in thread From: Borislav Petkov @ 2024-06-15 14:33 UTC (permalink / raw) To: kernel test robot; +Cc: Alexey Makhalov, oe-kbuild-all, linux-kernel, x86 On Sat, Jun 15, 2024 at 09:22:00PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vmware > head: ef08e7dc21307b226b5280d5e8cfea687bfd2866 > commit: e5ac9008b79c59235c34494e555419665022f5e1 [4/8] drm/vmwgfx: Use VMware hypercall API > config: i386-buildonly-randconfig-002-20240615 (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/config) > compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_open_channel.constprop.0': > >> vmwgfx_msg.c:(.text+0x203): undefined reference to `vmware_hypercall_slow' > ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_recv_msg': > vmwgfx_msg.c:(.text+0x46f): undefined reference to `vmware_hypercall_slow' > >> ld: vmwgfx_msg.c:(.text+0x49c): undefined reference to `vmware_hypercall_slow' > ld: vmwgfx_msg.c:(.text+0x4c3): undefined reference to `vmware_hypercall_slow' > ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_close_channel': > vmwgfx_msg.c:(.text+0x580): undefined reference to `vmware_hypercall_slow' > ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o:vmwgfx_msg.c:(.text+0x729): more undefined references to `vmware_hypercall_slow' follow > ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': > regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' > ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write': > regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync' > ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0': > regmap-spi.c:(.text+0x337): undefined reference to `spi_sync' > ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write': > regmap-spi.c:(.text+0x445): undefined reference to `spi_async' > ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init': > ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver' > > Kconfig warnings: (for reference only) > WARNING: unmet direct dependencies detected for REGMAP_SPI > Depends on [n]: SPI [=n] > Selected by [y]: > - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y]) > > -- Zapping tip:x86/vmware from the tip/master lineup for the time being, until this is fixed. Thx 0day guys for reporting. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' 2024-06-15 14:33 ` Borislav Petkov @ 2024-06-15 20:41 ` Alexey Makhalov 2024-06-15 21:41 ` Alexey Makhalov 1 sibling, 0 replies; 16+ messages in thread From: Alexey Makhalov @ 2024-06-15 20:41 UTC (permalink / raw) To: Borislav Petkov, kernel test robot; +Cc: oe-kbuild-all, linux-kernel, x86 Thanks for the report and provided .config file. The problem with DRM_VMWGFX=y when HYPERVISOR_GUEST is not set, i.e arch/x86/kernel/cpu/vmware.c is not built. It is even a problem today. For VMWARE_HYPERCALL alternative to work, vmware guest code must set cpu capabilities properly. The kernel based on the current config file will not work on a SEV-ES enabled machine. DRM_VMWGFX must depend on HYPERVISOR_GUEST similarly to VMWARE_BALLOON, MOUSE_PS2_VMMOUSE and PTP_1588_CLOCK_VMW. Borislav, I'm going to send a fix shortly. It has to be applied before this patchset. Thanks, --Alexey On 6/15/24 7:33 AM, Borislav Petkov wrote: > On Sat, Jun 15, 2024 at 09:22:00PM +0800, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vmware >> head: ef08e7dc21307b226b5280d5e8cfea687bfd2866 >> commit: e5ac9008b79c59235c34494e555419665022f5e1 [4/8] drm/vmwgfx: Use VMware hypercall API >> config: i386-buildonly-randconfig-002-20240615 (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/config) >> compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot <lkp@intel.com> >> | Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_open_channel.constprop.0': >>>> vmwgfx_msg.c:(.text+0x203): undefined reference to `vmware_hypercall_slow' >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_recv_msg': >> vmwgfx_msg.c:(.text+0x46f): undefined reference to `vmware_hypercall_slow' >>>> ld: vmwgfx_msg.c:(.text+0x49c): undefined reference to `vmware_hypercall_slow' >> ld: vmwgfx_msg.c:(.text+0x4c3): undefined reference to `vmware_hypercall_slow' >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_close_channel': >> vmwgfx_msg.c:(.text+0x580): undefined reference to `vmware_hypercall_slow' >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o:vmwgfx_msg.c:(.text+0x729): more undefined references to `vmware_hypercall_slow' follow >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': >> regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write': >> regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync' >> ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0': >> regmap-spi.c:(.text+0x337): undefined reference to `spi_sync' >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write': >> regmap-spi.c:(.text+0x445): undefined reference to `spi_async' >> ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init': >> ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver' >> >> Kconfig warnings: (for reference only) >> WARNING: unmet direct dependencies detected for REGMAP_SPI >> Depends on [n]: SPI [=n] >> Selected by [y]: >> - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y]) >> >> -- > > Zapping tip:x86/vmware from the tip/master lineup for the time being, until this > is fixed. > > Thx 0day guys for reporting. > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' 2024-06-15 14:33 ` Borislav Petkov 2024-06-15 20:41 ` Alexey Makhalov @ 2024-06-15 21:41 ` Alexey Makhalov 1 sibling, 0 replies; 16+ messages in thread From: Alexey Makhalov @ 2024-06-15 21:41 UTC (permalink / raw) To: Borislav Petkov, kernel test robot; +Cc: oe-kbuild-all, linux-kernel, x86 SPI warnings/errors are introduced by commit e77603d5468b90 ("iio: dac: support the ad9739a RF DAC") On 6/15/24 7:33 AM, Borislav Petkov wrote: > On Sat, Jun 15, 2024 at 09:22:00PM +0800, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vmware >> head: ef08e7dc21307b226b5280d5e8cfea687bfd2866 >> commit: e5ac9008b79c59235c34494e555419665022f5e1 [4/8] drm/vmwgfx: Use VMware hypercall API >> config: i386-buildonly-randconfig-002-20240615 (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/config) >> compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot <lkp@intel.com> >> | Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_open_channel.constprop.0': >>>> vmwgfx_msg.c:(.text+0x203): undefined reference to `vmware_hypercall_slow' >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_recv_msg': >> vmwgfx_msg.c:(.text+0x46f): undefined reference to `vmware_hypercall_slow' >>>> ld: vmwgfx_msg.c:(.text+0x49c): undefined reference to `vmware_hypercall_slow' >> ld: vmwgfx_msg.c:(.text+0x4c3): undefined reference to `vmware_hypercall_slow' >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_close_channel': >> vmwgfx_msg.c:(.text+0x580): undefined reference to `vmware_hypercall_slow' >> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o:vmwgfx_msg.c:(.text+0x729): more undefined references to `vmware_hypercall_slow' follow >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': >> regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write': >> regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync' >> ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0': >> regmap-spi.c:(.text+0x337): undefined reference to `spi_sync' >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write': >> regmap-spi.c:(.text+0x445): undefined reference to `spi_async' >> ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init': >> ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver' >> >> Kconfig warnings: (for reference only) >> WARNING: unmet direct dependencies detected for REGMAP_SPI >> Depends on [n]: SPI [=n] >> Selected by [y]: >> - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y]) >> >> -- > > Zapping tip:x86/vmware from the tip/master lineup for the time being, until this > is fixed. > > Thx 0day guys for reporting. > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-15 13:22 [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' kernel test robot 2024-06-15 14:33 ` Borislav Petkov @ 2024-06-16 1:25 ` Alexey Makhalov 2024-06-16 1:25 ` [PATCH 2/2] iio: dac: Fix dependencies of AD9739A Alexey Makhalov ` (2 more replies) 1 sibling, 3 replies; 16+ messages in thread From: Alexey Makhalov @ 2024-06-16 1:25 UTC (permalink / raw) To: linux-kernel, bp, bcm-kernel-feedback-list, lkp Cc: zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86, Alexey Makhalov VMWARE_HYPERCALL alternative will not work as intended without VMware guest code initialization. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> --- drivers/gpu/drm/vmwgfx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig index faddae3d6ac2..6f1ac940cbae 100644 --- a/drivers/gpu/drm/vmwgfx/Kconfig +++ b/drivers/gpu/drm/vmwgfx/Kconfig @@ -2,7 +2,7 @@ config DRM_VMWGFX tristate "DRM driver for VMware Virtual GPU" depends on DRM && PCI && MMU - depends on X86 || ARM64 + depends on (X86 && HYPERVISOR_GUEST) || ARM64 select DRM_TTM select DRM_TTM_HELPER select MAPPING_DIRTY_HELPERS -- 2.39.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] iio: dac: Fix dependencies of AD9739A 2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov @ 2024-06-16 1:25 ` Alexey Makhalov 2024-06-17 9:04 ` Borislav Petkov 2024-06-17 9:07 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Borislav Petkov 2024-06-19 9:55 ` [tip: x86/urgent] " tip-bot2 for Alexey Makhalov 2 siblings, 1 reply; 16+ messages in thread From: Alexey Makhalov @ 2024-06-16 1:25 UTC (permalink / raw) To: linux-kernel, bp, bcm-kernel-feedback-list, lkp Cc: zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86, Alexey Makhalov 0-DAY CI Kernel Test automation reported an issue: ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write': regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync' ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0': regmap-spi.c:(.text+0x337): undefined reference to `spi_sync' ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write': regmap-spi.c:(.text+0x445): undefined reference to `spi_async' ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init': ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver' Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for REGMAP_SPI Depends on [n]: SPI [=n] Selected by [y]: - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y]) The issue is caused by CONFIG_AD9739A=y when CONFIG_SPI is not set. Add explicit dependency on SPI and conditional selection of REGMAP_SPI. Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> --- drivers/iio/dac/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index 3c2bf620f00f..d095f4d26e49 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -133,8 +133,8 @@ config AD5624R_SPI config AD9739A tristate "Analog Devices AD9739A RF DAC spi driver" - depends on SPI || COMPILE_TEST - select REGMAP_SPI + depends on SPI + select REGMAP_SPI if SPI_MASTER select IIO_BACKEND help Say yes here to build support for Analog Devices AD9739A Digital-to -- 2.39.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] iio: dac: Fix dependencies of AD9739A 2024-06-16 1:25 ` [PATCH 2/2] iio: dac: Fix dependencies of AD9739A Alexey Makhalov @ 2024-06-17 9:04 ` Borislav Petkov 2024-06-17 20:48 ` Alexey Makhalov 0 siblings, 1 reply; 16+ messages in thread From: Borislav Petkov @ 2024-06-17 9:04 UTC (permalink / raw) To: Alexey Makhalov Cc: linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On Sat, Jun 15, 2024 at 06:25:11PM -0700, Alexey Makhalov wrote: > 0-DAY CI Kernel Test automation reported an issue: > > ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': > regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' > ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write': > regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync' > ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0': > regmap-spi.c:(.text+0x337): undefined reference to `spi_sync' > ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write': > regmap-spi.c:(.text+0x445): undefined reference to `spi_async' > ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init': > ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver' > > Kconfig warnings: (for reference only) > WARNING: unmet direct dependencies detected for REGMAP_SPI > Depends on [n]: SPI [=n] > Selected by [y]: > - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y]) > > The issue is caused by CONFIG_AD9739A=y when CONFIG_SPI is not set. > > Add explicit dependency on SPI and conditional selection of REGMAP_SPI. > > Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ > Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> > --- > drivers/iio/dac/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig > index 3c2bf620f00f..d095f4d26e49 100644 > --- a/drivers/iio/dac/Kconfig > +++ b/drivers/iio/dac/Kconfig > @@ -133,8 +133,8 @@ config AD5624R_SPI > > config AD9739A > tristate "Analog Devices AD9739A RF DAC spi driver" > - depends on SPI || COMPILE_TEST > - select REGMAP_SPI > + depends on SPI > + select REGMAP_SPI if SPI_MASTER > select IIO_BACKEND > help > Say yes here to build support for Analog Devices AD9739A Digital-to > -- FWIW, I appreciate it you fixing other breakages. However, there's a patch for that already, on its way: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=75183e461ce033605c3e85518a9f3d4e4ef848a3 Don't get discouraged, though, when fixing something that is not in our immediate area of interest! :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] iio: dac: Fix dependencies of AD9739A 2024-06-17 9:04 ` Borislav Petkov @ 2024-06-17 20:48 ` Alexey Makhalov 2024-06-17 21:02 ` Borislav Petkov 0 siblings, 1 reply; 16+ messages in thread From: Alexey Makhalov @ 2024-06-17 20:48 UTC (permalink / raw) To: Borislav Petkov Cc: linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On 6/17/24 2:04 AM, Borislav Petkov wrote: > On Sat, Jun 15, 2024 at 06:25:11PM -0700, Alexey Makhalov wrote: >> 0-DAY CI Kernel Test automation reported an issue: >> >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read': >> regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read' >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write': >> regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync' >> ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0': >> regmap-spi.c:(.text+0x337): undefined reference to `spi_sync' >> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write': >> regmap-spi.c:(.text+0x445): undefined reference to `spi_async' >> ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init': >> ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver' >> >> Kconfig warnings: (for reference only) >> WARNING: unmet direct dependencies detected for REGMAP_SPI >> Depends on [n]: SPI [=n] >> Selected by [y]: >> - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y]) >> >> The issue is caused by CONFIG_AD9739A=y when CONFIG_SPI is not set. >> >> Add explicit dependency on SPI and conditional selection of REGMAP_SPI. >> >> Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC") >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ >> Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> >> --- >> drivers/iio/dac/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig >> index 3c2bf620f00f..d095f4d26e49 100644 >> --- a/drivers/iio/dac/Kconfig >> +++ b/drivers/iio/dac/Kconfig >> @@ -133,8 +133,8 @@ config AD5624R_SPI >> >> config AD9739A >> tristate "Analog Devices AD9739A RF DAC spi driver" >> - depends on SPI || COMPILE_TEST >> - select REGMAP_SPI >> + depends on SPI >> + select REGMAP_SPI if SPI_MASTER >> select IIO_BACKEND >> help >> Say yes here to build support for Analog Devices AD9739A Digital-to >> -- > > FWIW, I appreciate it you fixing other breakages. However, there's a patch for > that already, on its way: > > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=75183e461ce033605c3e85518a9f3d4e4ef848a3 > > Don't get discouraged, though, when fixing something that is not in our > immediate area of interest! > > :-) > > Thx. > Lesson learned and noted for next time to address only related/new warnings and errors. Thanks! ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] iio: dac: Fix dependencies of AD9739A 2024-06-17 20:48 ` Alexey Makhalov @ 2024-06-17 21:02 ` Borislav Petkov 0 siblings, 0 replies; 16+ messages in thread From: Borislav Petkov @ 2024-06-17 21:02 UTC (permalink / raw) To: Alexey Makhalov Cc: linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On Mon, Jun 17, 2024 at 01:48:38PM -0700, Alexey Makhalov wrote: > > Don't get discouraged, though, when fixing something that is not in our > > immediate area of interest! > > > > :-) > > Lesson learned and noted for next time to address only related/new warnings > and errors. Thanks! I actually meant the exact opposite. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov 2024-06-16 1:25 ` [PATCH 2/2] iio: dac: Fix dependencies of AD9739A Alexey Makhalov @ 2024-06-17 9:07 ` Borislav Petkov 2024-06-17 10:01 ` Borislav Petkov 2024-06-17 20:51 ` Alexey Makhalov 2024-06-19 9:55 ` [tip: x86/urgent] " tip-bot2 for Alexey Makhalov 2 siblings, 2 replies; 16+ messages in thread From: Borislav Petkov @ 2024-06-17 9:07 UTC (permalink / raw) To: Alexey Makhalov Cc: linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote: > VMWARE_HYPERCALL alternative will not work as intended without > VMware guest code initialization. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ > Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> > --- > drivers/gpu/drm/vmwgfx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig > index faddae3d6ac2..6f1ac940cbae 100644 > --- a/drivers/gpu/drm/vmwgfx/Kconfig > +++ b/drivers/gpu/drm/vmwgfx/Kconfig > @@ -2,7 +2,7 @@ > config DRM_VMWGFX > tristate "DRM driver for VMware Virtual GPU" > depends on DRM && PCI && MMU > - depends on X86 || ARM64 > + depends on (X86 && HYPERVISOR_GUEST) || ARM64 > select DRM_TTM > select DRM_TTM_HELPER > select MAPPING_DIRTY_HELPERS > -- Right, I'll queue this soon but it doesn't reproduce here with gcc-11 or gcc-13. This must be something gcc-9 specific or so... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-17 9:07 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Borislav Petkov @ 2024-06-17 10:01 ` Borislav Petkov 2024-06-17 13:47 ` Zack Rusin 2024-06-17 20:51 ` Alexey Makhalov 1 sibling, 1 reply; 16+ messages in thread From: Borislav Petkov @ 2024-06-17 10:01 UTC (permalink / raw) To: Zack Rusin, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter Cc: Alexey Makhalov, linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On Mon, Jun 17, 2024 at 11:07:09AM +0200, Borislav Petkov wrote: > On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote: > > VMWARE_HYPERCALL alternative will not work as intended without > > VMware guest code initialization. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ > > Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> > > --- > > drivers/gpu/drm/vmwgfx/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig > > index faddae3d6ac2..6f1ac940cbae 100644 > > --- a/drivers/gpu/drm/vmwgfx/Kconfig > > +++ b/drivers/gpu/drm/vmwgfx/Kconfig > > @@ -2,7 +2,7 @@ > > config DRM_VMWGFX > > tristate "DRM driver for VMware Virtual GPU" > > depends on DRM && PCI && MMU > > - depends on X86 || ARM64 > > + depends on (X86 && HYPERVISOR_GUEST) || ARM64 > > select DRM_TTM > > select DRM_TTM_HELPER > > select MAPPING_DIRTY_HELPERS > > -- > > Right, I'll queue this soon but it doesn't reproduce here with gcc-11 or gcc-13. > This must be something gcc-9 specific or so... Actually, that's a DRM patch. Folks in To: ok to carry this though the tip tree? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-17 10:01 ` Borislav Petkov @ 2024-06-17 13:47 ` Zack Rusin 0 siblings, 0 replies; 16+ messages in thread From: Zack Rusin @ 2024-06-17 13:47 UTC (permalink / raw) To: Borislav Petkov Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Alexey Makhalov, linux-kernel, bcm-kernel-feedback-list, lkp, dri-devel, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On Mon, Jun 17, 2024 at 6:02 AM Borislav Petkov <bp@alien8.de> wrote: > > On Mon, Jun 17, 2024 at 11:07:09AM +0200, Borislav Petkov wrote: > > On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote: > > > VMWARE_HYPERCALL alternative will not work as intended without > > > VMware guest code initialization. > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ > > > Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> > > > --- > > > drivers/gpu/drm/vmwgfx/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig > > > index faddae3d6ac2..6f1ac940cbae 100644 > > > --- a/drivers/gpu/drm/vmwgfx/Kconfig > > > +++ b/drivers/gpu/drm/vmwgfx/Kconfig > > > @@ -2,7 +2,7 @@ > > > config DRM_VMWGFX > > > tristate "DRM driver for VMware Virtual GPU" > > > depends on DRM && PCI && MMU > > > - depends on X86 || ARM64 > > > + depends on (X86 && HYPERVISOR_GUEST) || ARM64 > > > select DRM_TTM > > > select DRM_TTM_HELPER > > > select MAPPING_DIRTY_HELPERS > > > -- > > > > Right, I'll queue this soon but it doesn't reproduce here with gcc-11 or gcc-13. > > This must be something gcc-9 specific or so... > > Actually, that's a DRM patch. > > Folks in To: ok to carry this though the tip tree? That's fine with me. Thanks. z ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-17 9:07 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Borislav Petkov 2024-06-17 10:01 ` Borislav Petkov @ 2024-06-17 20:51 ` Alexey Makhalov 2024-06-17 21:17 ` Borislav Petkov 1 sibling, 1 reply; 16+ messages in thread From: Alexey Makhalov @ 2024-06-17 20:51 UTC (permalink / raw) To: Borislav Petkov Cc: linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On 6/17/24 2:07 AM, Borislav Petkov wrote: > On Sat, Jun 15, 2024 at 06:25:10PM -0700, Alexey Makhalov wrote: >> VMWARE_HYPERCALL alternative will not work as intended without >> VMware guest code initialization. >> >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ >> Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> >> --- >> drivers/gpu/drm/vmwgfx/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig >> index faddae3d6ac2..6f1ac940cbae 100644 >> --- a/drivers/gpu/drm/vmwgfx/Kconfig >> +++ b/drivers/gpu/drm/vmwgfx/Kconfig >> @@ -2,7 +2,7 @@ >> config DRM_VMWGFX >> tristate "DRM driver for VMware Virtual GPU" >> depends on DRM && PCI && MMU >> - depends on X86 || ARM64 >> + depends on (X86 && HYPERVISOR_GUEST) || ARM64 >> select DRM_TTM >> select DRM_TTM_HELPER >> select MAPPING_DIRTY_HELPERS >> -- > > Right, I'll queue this soon but it doesn't reproduce here with gcc-11 or gcc-13. > This must be something gcc-9 specific or so... > Not really a gcc related, but the matter of a config file. It is reproducible if CONFIG_HYPERVISOR_GUEST not set, but CONFIG_DRM_VMWGFX=y. And this combination was allowed before the fix. Regards, --Alexey ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-17 20:51 ` Alexey Makhalov @ 2024-06-17 21:17 ` Borislav Petkov 2024-06-17 22:48 ` Alexey Makhalov 0 siblings, 1 reply; 16+ messages in thread From: Borislav Petkov @ 2024-06-17 21:17 UTC (permalink / raw) To: Alexey Makhalov Cc: linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On Mon, Jun 17, 2024 at 01:51:23PM -0700, Alexey Makhalov wrote: > Not really a gcc related, but the matter of a config file. It is > reproducible if CONFIG_HYPERVISOR_GUEST not set, but CONFIG_DRM_VMWGFX=y. > And this combination was allowed before the fix. Using their config: $ grep -E "(CONFIG_DRM_VMWGFX|CONFIG_HYPERVISOR_GUEST)" .config # CONFIG_HYPERVISOR_GUEST is not set CONFIG_DRM_VMWGFX=y CONFIG_DRM_VMWGFX_MKSSTATS=y $ make ... OBJCOPY arch/x86/boot/setup.bin BUILD arch/x86/boot/bzImage Kernel: arch/x86/boot/bzImage is ready (#2) $ gcc --version gcc (Debian 13.2.0-25) 13.2.0 $ So no, I can't reproduce with my compiler. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-17 21:17 ` Borislav Petkov @ 2024-06-17 22:48 ` Alexey Makhalov 0 siblings, 0 replies; 16+ messages in thread From: Alexey Makhalov @ 2024-06-17 22:48 UTC (permalink / raw) To: Borislav Petkov Cc: linux-kernel, bcm-kernel-feedback-list, lkp, zack.rusin, dri-devel, daniel, airlied, tzimmermann, mripard, maarten.lankhorst, linux-iio, jic23, lars, nuno.sa, dragos.bogdan, anshulusr, andrea.collamati, oe-kbuild-all, x86 On 6/17/24 2:17 PM, Borislav Petkov wrote: > On Mon, Jun 17, 2024 at 01:51:23PM -0700, Alexey Makhalov wrote: >> Not really a gcc related, but the matter of a config file. It is >> reproducible if CONFIG_HYPERVISOR_GUEST not set, but CONFIG_DRM_VMWGFX=y. >> And this combination was allowed before the fix. > > Using their config: > > $ grep -E "(CONFIG_DRM_VMWGFX|CONFIG_HYPERVISOR_GUEST)" .config > # CONFIG_HYPERVISOR_GUEST is not set > CONFIG_DRM_VMWGFX=y > CONFIG_DRM_VMWGFX_MKSSTATS=y > > $ make ... > > OBJCOPY arch/x86/boot/setup.bin > BUILD arch/x86/boot/bzImage > Kernel: arch/x86/boot/bzImage is ready (#2) > $ gcc --version > gcc (Debian 13.2.0-25) 13.2.0 > $ > > So no, I can't reproduce with my compiler. > That is interesting! Happy to debug it, but unfortunately I can not reproduce your "good" compilation without the fix. I tried "gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0" in Ubuntu, and "gcc (GCC) 12.2.0" in Photon OS. All of them fail with an "undefined reference to `vmware_hypercall_slow'" ^ permalink raw reply [flat|nested] 16+ messages in thread
* [tip: x86/urgent] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency 2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov 2024-06-16 1:25 ` [PATCH 2/2] iio: dac: Fix dependencies of AD9739A Alexey Makhalov 2024-06-17 9:07 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Borislav Petkov @ 2024-06-19 9:55 ` tip-bot2 for Alexey Makhalov 2 siblings, 0 replies; 16+ messages in thread From: tip-bot2 for Alexey Makhalov @ 2024-06-19 9:55 UTC (permalink / raw) To: linux-tip-commits Cc: kernel test robot, Alexey Makhalov, Borislav Petkov (AMD), x86, linux-kernel The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 8c4d6945fe5bd04ff847c3c788abd34ca354ecee Gitweb: https://git.kernel.org/tip/8c4d6945fe5bd04ff847c3c788abd34ca354ecee Author: Alexey Makhalov <alexey.makhalov@broadcom.com> AuthorDate: Sat, 15 Jun 2024 18:25:10 -07:00 Committer: Borislav Petkov (AMD) <bp@alien8.de> CommitterDate: Mon, 17 Jun 2024 11:56:54 +02:00 drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency VMWARE_HYPERCALL alternative will not work as intended without VMware guest code initialization. [ bp: note that this doesn't reproduce with newer gccs so it must be something gcc-9-specific. ] Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/ Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/20240616012511.198243-1-alexey.makhalov@broadcom.com --- drivers/gpu/drm/vmwgfx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig index faddae3..6f1ac94 100644 --- a/drivers/gpu/drm/vmwgfx/Kconfig +++ b/drivers/gpu/drm/vmwgfx/Kconfig @@ -2,7 +2,7 @@ config DRM_VMWGFX tristate "DRM driver for VMware Virtual GPU" depends on DRM && PCI && MMU - depends on X86 || ARM64 + depends on (X86 && HYPERVISOR_GUEST) || ARM64 select DRM_TTM select DRM_TTM_HELPER select MAPPING_DIRTY_HELPERS ^ permalink raw reply related [flat|nested] 16+ messages in thread
end of thread, other threads:[~2024-06-19 10:01 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-06-15 13:22 [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' kernel test robot 2024-06-15 14:33 ` Borislav Petkov 2024-06-15 20:41 ` Alexey Makhalov 2024-06-15 21:41 ` Alexey Makhalov 2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov 2024-06-16 1:25 ` [PATCH 2/2] iio: dac: Fix dependencies of AD9739A Alexey Makhalov 2024-06-17 9:04 ` Borislav Petkov 2024-06-17 20:48 ` Alexey Makhalov 2024-06-17 21:02 ` Borislav Petkov 2024-06-17 9:07 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Borislav Petkov 2024-06-17 10:01 ` Borislav Petkov 2024-06-17 13:47 ` Zack Rusin 2024-06-17 20:51 ` Alexey Makhalov 2024-06-17 21:17 ` Borislav Petkov 2024-06-17 22:48 ` Alexey Makhalov 2024-06-19 9:55 ` [tip: x86/urgent] " tip-bot2 for Alexey Makhalov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox