* [PATCH] drm/exynos/gem: Fix printk specifier for gem_object.size and dma_addr @ 2026-04-08 6:49 ` Chen-Yu Tsai 2026-05-06 6:36 ` Marek Szyprowski 0 siblings, 1 reply; 2+ messages in thread From: Chen-Yu Tsai @ 2026-04-08 6:49 UTC (permalink / raw) To: Inki Dae, Seung-Woo Kim, Kyungmin Park, Krzysztof Kozlowski, Alim Akhtar Cc: Chen-Yu Tsai, David Airlie, Simona Vetter, dri-devel, linux-samsung-soc, linux-arm-kernel, linux-kernel, kernel test robot In the recent change to use the GEM base object's size field instead of the exynos_gem object's additional field, the printk format was not adjusted for the change to size_t type. This causes a new warning on platforms on which size_t is not unsigned long. Fix this by using the correct "%zx" type. While at it, fix the specifier for dma_addr so that the cast to unsigned long is not longer needed. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202604081331.jSJQSVmg-lkp@intel.com/ Fixes: 11e898373fba ("drm/exynos: Drop exynos_drm_gem.size field") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- This is only compile tested. Build for ARM 32-bit confirms the warning is fixed. Sorry for the noise. The commit hash used in the Fixes tag is the current one seen in exynos-drm-next. --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index d9d42809a1a9..f264e170bc26 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -66,8 +66,8 @@ static int exynos_drm_alloc_buf(struct exynos_drm_gem *exynos_gem, bool kvmap) if (kvmap) exynos_gem->kvaddr = exynos_gem->cookie; - DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(0x%lx), size(0x%lx)\n", - (unsigned long)exynos_gem->dma_addr, exynos_gem->base.size); + DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(%pad), size(0x%zx)\n", + &exynos_gem->dma_addr, exynos_gem->base.size); return 0; } @@ -80,8 +80,8 @@ static void exynos_drm_free_buf(struct exynos_drm_gem *exynos_gem) return; } - DRM_DEV_DEBUG_KMS(dev->dev, "dma_addr(0x%lx), size(0x%lx)\n", - (unsigned long)exynos_gem->dma_addr, exynos_gem->base.size); + DRM_DEV_DEBUG_KMS(dev->dev, "dma_addr(%pad), size(0x%zx)\n", + &exynos_gem->dma_addr, exynos_gem->base.size); dma_free_attrs(drm_dev_dma_dev(dev), exynos_gem->base.size, exynos_gem->cookie, (dma_addr_t)exynos_gem->dma_addr, -- 2.53.0.1213.gd9a14994de-goog ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/exynos/gem: Fix printk specifier for gem_object.size and dma_addr 2026-04-08 6:49 ` [PATCH] drm/exynos/gem: Fix printk specifier for gem_object.size and dma_addr Chen-Yu Tsai @ 2026-05-06 6:36 ` Marek Szyprowski 0 siblings, 0 replies; 2+ messages in thread From: Marek Szyprowski @ 2026-05-06 6:36 UTC (permalink / raw) To: Chen-Yu Tsai, Inki Dae, Seung-Woo Kim, Kyungmin Park, Krzysztof Kozlowski, Alim Akhtar Cc: David Airlie, Simona Vetter, dri-devel, linux-samsung-soc, linux-arm-kernel, linux-kernel, kernel test robot On 08.04.2026 08:49, Chen-Yu Tsai wrote: > In the recent change to use the GEM base object's size field instead of > the exynos_gem object's additional field, the printk format was not > adjusted for the change to size_t type. This causes a new warning on > platforms on which size_t is not unsigned long. > > Fix this by using the correct "%zx" type. > > While at it, fix the specifier for dma_addr so that the cast to unsigned > long is not longer needed. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202604081331.jSJQSVmg-lkp@intel.com/ > Fixes: 11e898373fba ("drm/exynos: Drop exynos_drm_gem.size field") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > This is only compile tested. Build for ARM 32-bit confirms the warning > is fixed. Sorry for the noise. > > The commit hash used in the Fixes tag is the current one seen in > exynos-drm-next. > --- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c > index d9d42809a1a9..f264e170bc26 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c > @@ -66,8 +66,8 @@ static int exynos_drm_alloc_buf(struct exynos_drm_gem *exynos_gem, bool kvmap) > if (kvmap) > exynos_gem->kvaddr = exynos_gem->cookie; > > - DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(0x%lx), size(0x%lx)\n", > - (unsigned long)exynos_gem->dma_addr, exynos_gem->base.size); > + DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(%pad), size(0x%zx)\n", > + &exynos_gem->dma_addr, exynos_gem->base.size); > return 0; > } > > @@ -80,8 +80,8 @@ static void exynos_drm_free_buf(struct exynos_drm_gem *exynos_gem) > return; > } > > - DRM_DEV_DEBUG_KMS(dev->dev, "dma_addr(0x%lx), size(0x%lx)\n", > - (unsigned long)exynos_gem->dma_addr, exynos_gem->base.size); > + DRM_DEV_DEBUG_KMS(dev->dev, "dma_addr(%pad), size(0x%zx)\n", > + &exynos_gem->dma_addr, exynos_gem->base.size); > > dma_free_attrs(drm_dev_dma_dev(dev), exynos_gem->base.size, exynos_gem->cookie, > (dma_addr_t)exynos_gem->dma_addr, Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-06 6:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20260408064951eucas1p14200e8d85d270f16435e38af36dbcae0@eucas1p1.samsung.com>
2026-04-08 6:49 ` [PATCH] drm/exynos/gem: Fix printk specifier for gem_object.size and dma_addr Chen-Yu Tsai
2026-05-06 6:36 ` Marek Szyprowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox