The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2] drm/tegra: Fix dma-buf reference on import errors
@ 2026-10-31 10:44 Karl Mehltretter
  2026-11-19  6:26 ` Mikko Perttunen
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-10-31 10:44 UTC (permalink / raw)
  To: Thierry Reding, Mikko Perttunen
  Cc: Karl Mehltretter, David Airlie, Simona Vetter, Jonathan Hunter,
	Sumit Semwal, Christian König, Philipp Stanner, dri-devel,
	linux-tegra, linux-media, linaro-mm-sig, linux-kernel

tegra_bo_import() takes its own dma-buf reference only on success, but if
mapping fails, its detach error path still calls dma_buf_put(). That drops
the reference held by the PRIME caller, which then puts it again, and can
release the dma-buf file while its descriptor is still installed:

  VFS: Close: file count is 0 (f_op=dma_buf_fops)

Remove the unmatched put.

Fixes: f5b8794e17e4 ("drm/tegra: gem: Don't attach dma-bufs when not needed")
Cc: stable@vger.kernel.org
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
v2: Clean up the commit message (Mikko). No code change.
v1: https://lore.kernel.org/r/20261026055842.96484-1-kmehltretter@gmail.com/

Tested on a Jetson Nano (p3450-0000) with CONFIG_DMABUF_DEBUG=y and a local
change that rejects zero-byte IOMMU mappings to force the error path. Without
this patch the forced failure produced the warning above. With it, 100
consecutive failures returned -EINVAL, kept the original dma-buf fd and left
no dma-buf objects.

 drivers/gpu/drm/tegra/gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index f76af73..ed35a34 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -502,7 +502,6 @@ detach:
 		dma_buf_unmap_attachment_unlocked(attach, bo->sgt, DMA_TO_DEVICE);
 
 	dma_buf_detach(buf, attach);
-	dma_buf_put(buf);
 free:
 	drm_gem_object_release(&bo->gem);
 	kfree(bo);

base-commit: 21a7f44fd0765fcc5194130b28767786eba1d1e7
-- 
2.39.5 (Apple Git-154)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] drm/tegra: Fix dma-buf reference on import errors
  2026-10-31 10:44 [PATCH v2] drm/tegra: Fix dma-buf reference on import errors Karl Mehltretter
@ 2026-11-19  6:26 ` Mikko Perttunen
  0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2026-11-19  6:26 UTC (permalink / raw)
  To: Thierry Reding, linux-media
  Cc: Karl Mehltretter, David Airlie, Simona Vetter, Jonathan Hunter,
	Sumit Semwal, Christian König, Philipp Stanner, dri-devel,
	linux-tegra, linux-media, linaro-mm-sig, linux-kernel,
	Karl Mehltretter

On Saturday, October 31, 2026 7:44 PM Karl Mehltretter wrote:
> tegra_bo_import() takes its own dma-buf reference only on success, but if
> mapping fails, its detach error path still calls dma_buf_put(). That drops
> the reference held by the PRIME caller, which then puts it again, and can
> release the dma-buf file while its descriptor is still installed:
> 
>   VFS: Close: file count is 0 (f_op=dma_buf_fops)
> 
> Remove the unmatched put.
> 
> Fixes: f5b8794e17e4 ("drm/tegra: gem: Don't attach dma-bufs when not needed")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> v2: Clean up the commit message (Mikko). No code change.
> v1: https://lore.kernel.org/r/20261026055842.96484-1-kmehltretter@gmail.com/
> 
> Tested on a Jetson Nano (p3450-0000) with CONFIG_DMABUF_DEBUG=y and a local
> change that rejects zero-byte IOMMU mappings to force the error path. Without
> this patch the forced failure produced the warning above. With it, 100
> consecutive failures returned -EINVAL, kept the original dma-buf fd and left
> no dma-buf objects.
> 
>  drivers/gpu/drm/tegra/gem.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index f76af73..ed35a34 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -502,7 +502,6 @@ detach:
>  		dma_buf_unmap_attachment_unlocked(attach, bo->sgt, DMA_TO_DEVICE);
>  
>  	dma_buf_detach(buf, attach);
> -	dma_buf_put(buf);
>  free:
>  	drm_gem_object_release(&bo->gem);
>  	kfree(bo);
> 
> base-commit: 21a7f44fd0765fcc5194130b28767786eba1d1e7
> -- 
> 2.39.5 (Apple Git-154)
> 
> 

Thank you

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-19  6:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-31 10:44 [PATCH v2] drm/tegra: Fix dma-buf reference on import errors Karl Mehltretter
2026-11-19  6:26 ` Mikko Perttunen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox