From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>, linux-wireless@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
Avraham Stern <avraham.stern@intel.com>,
Daniel Gabay <daniel.gabay@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Johannes Berg <johannes.berg@intel.com>,
Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>,
Yedidya Benshimol <yedidya.ben.shimol@intel.com>
Subject: Re: [PATCH] wifi: iwlwifi: Fix uninitialized variable with __free()
Date: Wed, 12 Mar 2025 16:42:18 +0100 [thread overview]
Message-ID: <1b32cd5b-aa46-4a23-bd21-908196c4bab3@web.de> (raw)
In-Reply-To: <f7c17a7f-f173-43bf-bc39-316b8adde349@stanley.mountain>
…
> +++ b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> @@ -556,8 +556,8 @@ iwl_dbgfs_vif_twt_setup_write(struct iwl_mld *mld, char *buf, size_t count,
> };
> struct ieee80211_vif *vif = data;
> struct iwl_mld_vif *mld_vif = iwl_mld_vif_from_mac80211(vif);
> + struct iwl_dhc_cmd *cmd __free(kfree) = NULL;
> struct iwl_dhc_twt_operation *dhc_twt_cmd;
> - struct iwl_dhc_cmd *cmd __free(kfree);
…
Can it be recommended to reduce the scope for the affected local variable instead?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/cleanup.h#L129-L133
Regards,
Markus
next prev parent reply other threads:[~2025-03-12 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 8:31 [PATCH next] wifi: iwlwifi: Fix uninitialized variable with __free() Dan Carpenter
2025-03-12 9:37 ` Korenblit, Miriam Rachel
2025-03-12 15:15 ` Jeff Johnson
2025-03-12 15:24 ` Dan Carpenter
2025-03-13 17:43 ` Jeff Johnson
2025-03-12 19:27 ` Korenblit, Miriam Rachel
2025-03-12 15:42 ` Markus Elfring [this message]
2025-03-12 19:32 ` [PATCH] " Korenblit, Miriam Rachel
2025-03-12 20:16 ` Markus Elfring
2025-03-12 20:32 ` Korenblit, Miriam Rachel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b32cd5b-aa46-4a23-bd21-908196c4bab3@web.de \
--to=markus.elfring@web.de \
--cc=avraham.stern@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel.gabay@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=yedidya.ben.shimol@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox