From: Markus Elfring <Markus.Elfring@web.de>
To: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-wireless@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
Avraham Stern <avraham.stern@intel.com>,
Daniel Gabay <daniel.gabay@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Johannes Berg <johannes.berg@intel.com>,
Yedidya Benshimol <yedidya.ben.shimol@intel.com>
Subject: Re: wifi: iwlwifi: Fix uninitialized variable with __free()
Date: Wed, 12 Mar 2025 21:16:42 +0100 [thread overview]
Message-ID: <7ea83bd5-b19b-4bd8-ac2a-8fb2ad616f8b@web.de> (raw)
In-Reply-To: <MW5PR11MB5810329D2D44A188239D3093A3D02@MW5PR11MB5810.namprd11.prod.outlook.com>
>> Can it be recommended to reduce the scope for the affected local variable instead?
>> https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/cleanup.h#L129-L133
>
> As said in reply to Jeff's review -
> This is recommended if you have multiple __kfree variables (and the order of freeing matters)
> Or if there is a guard() later in the function.
How does such a view fit to the documentation of this programming interface?
Regards,
Markus
next prev parent reply other threads:[~2025-03-12 20:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 8:31 [PATCH next] wifi: iwlwifi: Fix uninitialized variable with __free() Dan Carpenter
2025-03-12 9:37 ` Korenblit, Miriam Rachel
2025-03-12 15:15 ` Jeff Johnson
2025-03-12 15:24 ` Dan Carpenter
2025-03-13 17:43 ` Jeff Johnson
2025-03-12 19:27 ` Korenblit, Miriam Rachel
2025-03-12 15:42 ` [PATCH] " Markus Elfring
2025-03-12 19:32 ` Korenblit, Miriam Rachel
2025-03-12 20:16 ` Markus Elfring [this message]
2025-03-12 20:32 ` Korenblit, Miriam Rachel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea83bd5-b19b-4bd8-ac2a-8fb2ad616f8b@web.de \
--to=markus.elfring@web.de \
--cc=avraham.stern@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel.gabay@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=yedidya.ben.shimol@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).