From: Crystal Wood <crwood@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>, Tomas Glozar <tglozar@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
John Kacur <jkacur@redhat.com>,
Luis Goncalves <lgoncalv@redhat.com>,
Costa Shulyupin <costa.shul@redhat.com>,
Wander Lairson Costa <wander@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-trace-kernel <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tracing/osnoise: Add option to align tlat threads
Date: Tue, 14 Apr 2026 13:35:52 -0500 [thread overview]
Message-ID: <1bc700d91efea3936bfebe77c058f3c402c16aa4.camel@redhat.com> (raw)
In-Reply-To: <20260414080339.26193a6b@robin>
On Tue, 2026-04-14 at 08:03 -0400, Steven Rostedt wrote:
> I noticed that I never ran this through my tests, and I just did now,
> and it failed with:
>
> /work/build/trace/nobackup/linux-test.git/kernel/trace/trace_osnoise.c: In function ‘osnoise_workload_start’:
> /work/build/trace/nobackup/linux-test.git/kernel/trace/trace_osnoise.c:2929:23: error: ‘align_next’ undeclared (first use in this function); did you mean ‘klist_next’?
> 2929 | atomic64_set(&align_next, 0);
> | ^~~~~~~~~~
> | klist_next
> /work/build/trace/nobackup/linux-test.git/kernel/trace/trace_osnoise.c:2929:23: note: each undeclared identifier is reported only once for each function it appears in
> CC [M] drivers/net/ethernet/mellanox/mlx5/core/diag/crdump.o
> make[5]: *** [/work/build/trace/nobackup/linux-test.git/scripts/Makefile.build:289: kernel/trace/trace_osnoise.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
Looks like this should be moved into tlat_var_reset().
-Crystal
prev parent reply other threads:[~2026-04-14 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 13:13 [PATCH v2] tracing/osnoise: Add option to align tlat threads Tomas Glozar
2026-03-30 16:00 ` Wander Lairson Costa
2026-03-30 19:43 ` Crystal Wood
2026-04-14 12:03 ` Steven Rostedt
2026-04-14 18:35 ` Crystal Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bc700d91efea3936bfebe77c058f3c402c16aa4.camel@redhat.com \
--to=crwood@redhat.com \
--cc=costa.shul@redhat.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox