* [PATCH v2 1/1] cxl/feature: Update out_len in set feature failure case
@ 2025-04-09 2:25 Li Ming
2025-04-09 15:37 ` Dave Jiang
2025-04-09 17:58 ` Ira Weiny
0 siblings, 2 replies; 4+ messages in thread
From: Li Ming @ 2025-04-09 2:25 UTC (permalink / raw)
To: dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel, Li Ming
CXL subsystem supports userspace to configure features via fwctl
interface, it will configure features by using Set Feature command.
Whatever Set Feature succeeds or fails, CXL driver always needs to
return a structure fwctl_rpc_cxl_out to caller, and returned size is
updated in a out_len parameter. The out_len should be updated not only
when the set feature succeeds, but also when the set feature fails.
Signed-off-by: Li Ming <ming.li@zohomail.com>
---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 v6.15-rc1
v2:
- Adjust changelog
---
drivers/cxl/core/features.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
index f4daefe3180e..066dfc29a3dd 100644
--- a/drivers/cxl/core/features.c
+++ b/drivers/cxl/core/features.c
@@ -528,13 +528,13 @@ static void *cxlctl_set_feature(struct cxl_features_state *cxlfs,
rc = cxl_set_feature(cxl_mbox, &feat_in->uuid,
feat_in->version, feat_in->feat_data,
data_size, flags, offset, &return_code);
+ *out_len = sizeof(*rpc_out);
if (rc) {
rpc_out->retval = return_code;
return no_free_ptr(rpc_out);
}
rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
- *out_len = sizeof(*rpc_out);
return no_free_ptr(rpc_out);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] cxl/feature: Update out_len in set feature failure case
2025-04-09 2:25 [PATCH v2 1/1] cxl/feature: Update out_len in set feature failure case Li Ming
@ 2025-04-09 15:37 ` Dave Jiang
2025-04-10 1:02 ` Li Ming
2025-04-09 17:58 ` Ira Weiny
1 sibling, 1 reply; 4+ messages in thread
From: Dave Jiang @ 2025-04-09 15:37 UTC (permalink / raw)
To: Li Ming, dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel
On 4/8/25 7:25 PM, Li Ming wrote:
> CXL subsystem supports userspace to configure features via fwctl
> interface, it will configure features by using Set Feature command.
> Whatever Set Feature succeeds or fails, CXL driver always needs to
> return a structure fwctl_rpc_cxl_out to caller, and returned size is
> updated in a out_len parameter. The out_len should be updated not only
> when the set feature succeeds, but also when the set feature fails.
Good catch! Can you add a Fixes tag please? Otherwise
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 v6.15-rc1
>
> v2:
> - Adjust changelog
> ---
> drivers/cxl/core/features.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index f4daefe3180e..066dfc29a3dd 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -528,13 +528,13 @@ static void *cxlctl_set_feature(struct cxl_features_state *cxlfs,
> rc = cxl_set_feature(cxl_mbox, &feat_in->uuid,
> feat_in->version, feat_in->feat_data,
> data_size, flags, offset, &return_code);
> + *out_len = sizeof(*rpc_out);
> if (rc) {
> rpc_out->retval = return_code;
> return no_free_ptr(rpc_out);
> }
>
> rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
> - *out_len = sizeof(*rpc_out);
>
> return no_free_ptr(rpc_out);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] cxl/feature: Update out_len in set feature failure case
2025-04-09 15:37 ` Dave Jiang
@ 2025-04-10 1:02 ` Li Ming
0 siblings, 0 replies; 4+ messages in thread
From: Li Ming @ 2025-04-10 1:02 UTC (permalink / raw)
To: Dave Jiang
Cc: linux-cxl, linux-kernel, dave, jonathan.cameron, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
On 4/9/2025 11:37 PM, Dave Jiang wrote:
>
> On 4/8/25 7:25 PM, Li Ming wrote:
>> CXL subsystem supports userspace to configure features via fwctl
>> interface, it will configure features by using Set Feature command.
>> Whatever Set Feature succeeds or fails, CXL driver always needs to
>> return a structure fwctl_rpc_cxl_out to caller, and returned size is
>> updated in a out_len parameter. The out_len should be updated not only
>> when the set feature succeeds, but also when the set feature fails.
> Good catch! Can you add a Fixes tag please? Otherwise
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>、
Yes, forgot to add a Fixes tag. Thanks for that.
Ming
>
>> Signed-off-by: Li Ming <ming.li@zohomail.com>
>> ---
>> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 v6.15-rc1
>>
>> v2:
>> - Adjust changelog
>> ---
>> drivers/cxl/core/features.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
>> index f4daefe3180e..066dfc29a3dd 100644
>> --- a/drivers/cxl/core/features.c
>> +++ b/drivers/cxl/core/features.c
>> @@ -528,13 +528,13 @@ static void *cxlctl_set_feature(struct cxl_features_state *cxlfs,
>> rc = cxl_set_feature(cxl_mbox, &feat_in->uuid,
>> feat_in->version, feat_in->feat_data,
>> data_size, flags, offset, &return_code);
>> + *out_len = sizeof(*rpc_out);
>> if (rc) {
>> rpc_out->retval = return_code;
>> return no_free_ptr(rpc_out);
>> }
>>
>> rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
>> - *out_len = sizeof(*rpc_out);
>>
>> return no_free_ptr(rpc_out);
>> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] cxl/feature: Update out_len in set feature failure case
2025-04-09 2:25 [PATCH v2 1/1] cxl/feature: Update out_len in set feature failure case Li Ming
2025-04-09 15:37 ` Dave Jiang
@ 2025-04-09 17:58 ` Ira Weiny
1 sibling, 0 replies; 4+ messages in thread
From: Ira Weiny @ 2025-04-09 17:58 UTC (permalink / raw)
To: Li Ming, dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel, Li Ming
Li Ming wrote:
> CXL subsystem supports userspace to configure features via fwctl
> interface, it will configure features by using Set Feature command.
> Whatever Set Feature succeeds or fails, CXL driver always needs to
> return a structure fwctl_rpc_cxl_out to caller, and returned size is
> updated in a out_len parameter. The out_len should be updated not only
> when the set feature succeeds, but also when the set feature fails.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
>
With fixes tag Dave found.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 v6.15-rc1
>
> v2:
> - Adjust changelog
> ---
> drivers/cxl/core/features.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index f4daefe3180e..066dfc29a3dd 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -528,13 +528,13 @@ static void *cxlctl_set_feature(struct cxl_features_state *cxlfs,
> rc = cxl_set_feature(cxl_mbox, &feat_in->uuid,
> feat_in->version, feat_in->feat_data,
> data_size, flags, offset, &return_code);
> + *out_len = sizeof(*rpc_out);
> if (rc) {
> rpc_out->retval = return_code;
> return no_free_ptr(rpc_out);
> }
>
> rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
> - *out_len = sizeof(*rpc_out);
>
> return no_free_ptr(rpc_out);
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-10 1:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-09 2:25 [PATCH v2 1/1] cxl/feature: Update out_len in set feature failure case Li Ming
2025-04-09 15:37 ` Dave Jiang
2025-04-10 1:02 ` Li Ming
2025-04-09 17:58 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox