* [PATCH] hwmon: (nct6683) Add customer ID for ASRock B650 Steel Legend WiFi
@ 2024-12-14 10:22 Max Ammann
2024-12-14 15:12 ` Guenter Roeck
2024-12-23 7:57 ` Russell Haley
0 siblings, 2 replies; 3+ messages in thread
From: Max Ammann @ 2024-12-14 10:22 UTC (permalink / raw)
To: jdelvare; +Cc: linux, linux-hwmon, linux-kernel, Max Ammann
This value was found on an ASRock B650 Steel Legend WiFi with an
NCT6686D chip.
Signed-off-by: Max Ammann <max@maxammann.org>
---
Documentation/hwmon/nct6683.rst | 1 +
drivers/hwmon/nct6683.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
index 2a7a78eb1b46..f224639229d2 100644
--- a/Documentation/hwmon/nct6683.rst
+++ b/Documentation/hwmon/nct6683.rst
@@ -63,6 +63,7 @@ Intel DH87MC NCT6683D EC firmware version 1.0 build 04/03/13
Intel DB85FL NCT6683D EC firmware version 1.0 build 04/03/13
ASRock X570 NCT6683D EC firmware version 1.0 build 06/28/19
ASRock X670E NCT6686D EC firmware version 1.0 build 05/19/22
+ASRock B650 Steel Legend WiFi NCT6686D EC firmware version 1.0 build 11/09/23
MSI B550 NCT6687D EC firmware version 1.0 build 05/07/20
MSI X670-P NCT6687D EC firmware version 0.0 build 09/27/22
=============== ===============================================
diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index f71615e06a8f..3d31b8e2c835 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -178,6 +178,7 @@ superio_exit(int ioreg)
#define NCT6683_CUSTOMER_ID_ASROCK 0xe2c
#define NCT6683_CUSTOMER_ID_ASROCK2 0xe1b
#define NCT6683_CUSTOMER_ID_ASROCK3 0x1631
+#define NCT6683_CUSTOMER_ID_ASROCK4 0x163e
#define NCT6683_REG_BUILD_YEAR 0x604
#define NCT6683_REG_BUILD_MONTH 0x605
@@ -1233,6 +1234,8 @@ static int nct6683_probe(struct platform_device *pdev)
break;
case NCT6683_CUSTOMER_ID_ASROCK3:
break;
+ case NCT6683_CUSTOMER_ID_ASROCK4:
+ break;
default:
if (!force)
return -ENODEV;
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (nct6683) Add customer ID for ASRock B650 Steel Legend WiFi
2024-12-14 10:22 [PATCH] hwmon: (nct6683) Add customer ID for ASRock B650 Steel Legend WiFi Max Ammann
@ 2024-12-14 15:12 ` Guenter Roeck
2024-12-23 7:57 ` Russell Haley
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2024-12-14 15:12 UTC (permalink / raw)
To: Max Ammann; +Cc: jdelvare, linux-hwmon, linux-kernel
On Sat, Dec 14, 2024 at 11:22:01AM +0100, Max Ammann wrote:
> This value was found on an ASRock B650 Steel Legend WiFi with an
> NCT6686D chip.
>
> Signed-off-by: Max Ammann <max@maxammann.org>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (nct6683) Add customer ID for ASRock B650 Steel Legend WiFi
2024-12-14 10:22 [PATCH] hwmon: (nct6683) Add customer ID for ASRock B650 Steel Legend WiFi Max Ammann
2024-12-14 15:12 ` Guenter Roeck
@ 2024-12-23 7:57 ` Russell Haley
1 sibling, 0 replies; 3+ messages in thread
From: Russell Haley @ 2024-12-23 7:57 UTC (permalink / raw)
To: Max Ammann, jdelvare; +Cc: linux, linux-hwmon, linux-kernel
I just modprobed it with force=1 on an Asrock Z890 Pro-A Wifi and:
> [11107.683746] nct6683: Found NCT6686D or compatible chip at 0x2e:0xa20
> [11107.683920] nct6683 nct6683.2592: Enabling support for unknown customer ID 0x163d
> [11107.687827] nct6683 nct6683.2592: NCT6686D EC firmware version 1.0 build 08/30/24
I don't know what the standard for this is, but you could perhaps throw
0x163d in too, if this is sufficient information to prove it's safe.
Nothing visibly went wrong, and it reads voltages and fan speeds, but
the pwms are all read-only.
On 12/14/24 4:22 AM, Max Ammann wrote:
> This value was found on an ASRock B650 Steel Legend WiFi with an
> NCT6686D chip.
>
> Signed-off-by: Max Ammann <max@maxammann.org>
> ---
> Documentation/hwmon/nct6683.rst | 1 +
> drivers/hwmon/nct6683.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
> index 2a7a78eb1b46..f224639229d2 100644
> --- a/Documentation/hwmon/nct6683.rst
> +++ b/Documentation/hwmon/nct6683.rst
> @@ -63,6 +63,7 @@ Intel DH87MC NCT6683D EC firmware version 1.0 build 04/03/13
> Intel DB85FL NCT6683D EC firmware version 1.0 build 04/03/13
> ASRock X570 NCT6683D EC firmware version 1.0 build 06/28/19
> ASRock X670E NCT6686D EC firmware version 1.0 build 05/19/22
> +ASRock B650 Steel Legend WiFi NCT6686D EC firmware version 1.0 build 11/09/23
> MSI B550 NCT6687D EC firmware version 1.0 build 05/07/20
> MSI X670-P NCT6687D EC firmware version 0.0 build 09/27/22
> =============== ===============================================
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index f71615e06a8f..3d31b8e2c835 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -178,6 +178,7 @@ superio_exit(int ioreg)
> #define NCT6683_CUSTOMER_ID_ASROCK 0xe2c
> #define NCT6683_CUSTOMER_ID_ASROCK2 0xe1b
> #define NCT6683_CUSTOMER_ID_ASROCK3 0x1631
> +#define NCT6683_CUSTOMER_ID_ASROCK4 0x163e
>
> #define NCT6683_REG_BUILD_YEAR 0x604
> #define NCT6683_REG_BUILD_MONTH 0x605
> @@ -1233,6 +1234,8 @@ static int nct6683_probe(struct platform_device *pdev)
> break;
> case NCT6683_CUSTOMER_ID_ASROCK3:
> break;
> + case NCT6683_CUSTOMER_ID_ASROCK4:
> + break;
> default:
> if (!force)
> return -ENODEV;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-23 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-14 10:22 [PATCH] hwmon: (nct6683) Add customer ID for ASRock B650 Steel Legend WiFi Max Ammann
2024-12-14 15:12 ` Guenter Roeck
2024-12-23 7:57 ` Russell Haley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox